[BUG] Carbon txt looks trigger integrity error from sitecheck IP ranges #281
Labels
bug
Something isn't working
Severity: high
Bug severity level
Severity: low
Bug severity level
Severity: medium
Bug severity level
Please choose the appropriate severity level accompanied by this report by removing the exess severity labels.
Describe the bug
When we do a lookup using the carbon.txt method, because we are using a domain based lookup instead of a IP based lookup, we are seeing integrity exceptions, because the table is expecting a number representing an IP address.
To Reproduce
Run a check on a domain where we only have carbon.txt related information.
Expected behavior
We should be able to successfully log these lookups, and pass an number of 0 as our IP in.
Actual behavior
The
SiteCheckLogger
will try to log a sitecheck that has aip
ofNone
and anmatch_ip_range
ofNone
.An integrity error
(1048, "Column 'id_greencheck' cannot be null)
exception stops the look up being logged successfully.Carbon.txt isn't really an officially supported protocol so we see relatively few checks, and subsequently errors of this kind in our exception notifier.
Our handling of IP addresses for carbon.txt isn't something we have really defined that well for this table, and the Sitecheck code could do with some love anyway. This issue is resolved when we have:
The text was updated successfully, but these errors were encountered: