Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Carbon txt looks trigger integrity error from sitecheck IP ranges #281

Open
2 tasks
mrchrisadams opened this issue Aug 10, 2022 · 0 comments
Open
2 tasks
Labels
bug Something isn't working Severity: high Bug severity level Severity: low Bug severity level Severity: medium Bug severity level

Comments

@mrchrisadams
Copy link
Member

mrchrisadams commented Aug 10, 2022

Please choose the appropriate severity level accompanied by this report by removing the exess severity labels.

Describe the bug
When we do a lookup using the carbon.txt method, because we are using a domain based lookup instead of a IP based lookup, we are seeing integrity exceptions, because the table is expecting a number representing an IP address.

To Reproduce

Run a check on a domain where we only have carbon.txt related information.

Expected behavior

We should be able to successfully log these lookups, and pass an number of 0 as our IP in.

Actual behavior

The SiteCheckLogger will try to log a sitecheck that has a ip of None and an match_ip_range of None.

An integrity error (1048, "Column 'id_greencheck' cannot be null) exception stops the look up being logged successfully.


Carbon.txt isn't really an officially supported protocol so we see relatively few checks, and subsequently errors of this kind in our exception notifier.

Our handling of IP addresses for carbon.txt isn't something we have really defined that well for this table, and the Sitecheck code could do with some love anyway. This issue is resolved when we have:

  • a clearly documented approach for handling carbon.txt lookups
  • no exceptions triggered when logging them
@mrchrisadams mrchrisadams added bug Something isn't working Severity: high Bug severity level Severity: medium Bug severity level Severity: low Bug severity level labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Severity: high Bug severity level Severity: low Bug severity level Severity: medium Bug severity level
Projects
None yet
Development

No branches or pull requests

1 participant