Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow easy use of GitHub Action's CHROMEWEBDRIVER environment variable #1159

Open
jason0x43 opened this issue May 28, 2020 · 2 comments
Open
Labels
effort-medium This may take a couple of days enhancement A new or improved feature priority-medium This should get done, but it's not a high priority repo-digdug Resolution applies to @theintern/digdug

Comments

@jason0x43
Copy link
Member

GitHub Actions virtual environments (linux and windows) expose a CHROMEWEBDRIVER environment variable that points to the local chromedriver.exe. Intern should be able to use this information to allow use of the existing webdriver vs downloading a new one.

This could be accomplished in a couple of ways:

  1. Update SeleniumTunnel to understand CHROMEWEBDRIVER (and FIREFOXWEBDRIVER, etc) env vars
  2. Update the config processing code to understand env vars (which would be more generally useful). This would also require updating dig dug to allow executables to be specified for drivers.
@jason0x43 jason0x43 added enhancement A new or improved feature effort-medium This may take a couple of days repo-digdug Resolution applies to @theintern/digdug priority-medium This should get done, but it's not a high priority labels May 28, 2020
@dstaley
Copy link

dstaley commented Jun 2, 2020

It looks like the environment variable ChromeWebDriver points to the folder where the webdriver is installed. So determining the version would include executing the chromedriver contained within the folder and parsing out the version string.

> chromedriver --version
ChromeDriver 83.0.4103.39 (ccbf011cb2d2b19b506d844400483861342c20cd-refs/branch-heads/4103@{#416})

As an alternative, you could also just execute chromedriver --version directly since it's already in the PATH.

@jason0x43
Copy link
Member Author

That's a good idea; Intern could check for the existence of a webdriver in the path before deciding to download one, or we could use a dedicated version string like "local" to tell Intern to assume a driver is in the path.

keithamus added a commit to keithamus/turbo that referenced this issue Mar 30, 2022
Pins Intern chromedriver to the one available in actions

Refs theintern/intern#1159

Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
keithamus added a commit to keithamus/turbo that referenced this issue Mar 30, 2022
Pins Intern chromedriver to the one available in actions

Refs theintern/intern#1159

Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
keithamus added a commit to keithamus/turbo that referenced this issue Mar 30, 2022
Pins Intern chromedriver to the one available in actions

Refs theintern/intern#1159

Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
keithamus added a commit to keithamus/turbo that referenced this issue Mar 30, 2022
Pins Intern chromedriver to the one available in actions

Refs theintern/intern#1159

Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
keithamus added a commit to keithamus/turbo that referenced this issue Mar 30, 2022
Pins Intern chromedriver to the one available in actions

Refs theintern/intern#1159

Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
keithamus added a commit to keithamus/turbo that referenced this issue Mar 30, 2022
Pins Intern chromedriver to the one available in actions

Refs theintern/intern#1159

Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
dhh pushed a commit to hotwired/turbo that referenced this issue Mar 30, 2022
* upgrade all dependencies

* cast unknown error as Error

* add skipLibCheck to tsconfig

We only have devDeps so no need to check them

* upgrade typescript to latest

* set intern CHROMEDRIVER version

Pins Intern chromedriver to the one available in actions

Refs theintern/intern#1159

Co-authored-by: Kristján Oddsson <koddsson@gmail.com>

Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-medium This may take a couple of days enhancement A new or improved feature priority-medium This should get done, but it's not a high priority repo-digdug Resolution applies to @theintern/digdug
Projects
None yet
Development

No branches or pull requests

2 participants