Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal doesn't close if you go back a page on your website. #33

Closed
YonatanToker opened this issue Mar 13, 2024 · 6 comments
Closed

Modal doesn't close if you go back a page on your website. #33

YonatanToker opened this issue Mar 13, 2024 · 6 comments

Comments

@YonatanToker
Copy link

YonatanToker commented Mar 13, 2024 •
edited
Loading

2024-03-13.22-01-56.mp4

If you go back your cannot click on anything you must refresh the page.
@YonatanToker YonatanToker changed the title Modal doesn't close if you go back a page on your website. Saved on a global Modal doesn't close if you go back a page on your website. Mar 13, 2024
@TjasaZil
Copy link

I would like to be assigned to this issue, if it still needs to be done

@MGREMY MGREMY mentioned this issue Aug 8, 2024
Merged
30 tasks
@MGREMY
Copy link
Collaborator

MGREMY commented Aug 8, 2024 •
edited
Loading

@TjasaZil Hey
Sorry for the (very) late response
I tagged this issue in #46
If you want to fix this issue, feel free to do :)

@TjasaZil
Copy link

TjasaZil commented Aug 8, 2024

@MGREMY No problem. I will fix the issue :)

bence444 added a commit to bence444/flowbite-angular that referenced this issue Oct 7, 2024
@bence444
fix(modal): close on route change themesberg#33
3896bc7
MGREMY pushed a commit that referenced this issue Oct 7, 2024
@bence444
fix(modal): close on route change #33 (#56)
c9c67b9 
* fix(modal): close on route change #33

* fix(modal): close on backdrop click

* fix(modal): use signal based viewChild instead of @ViewChild

* fix(modal): set z-index to 99

* fix(modal): update ModalClass to not apply any class on the host
MGREMY added a commit that referenced this issue Oct 24, 2024
@MGREMY @ross1296 @bence444
Rework documentation front (#46)
1c0296a 
* docs: rework front

update routing

* style: edit eslint and prettier config

* test: fix test for components after update

* refactor: clean html template with prettier conf

* perf: remove unused dependencies

* fix: development/production config with nx start

* docs: add icons from figma

* docs: remove svg dark:hidden

* docs: make home page responsive for mobile

* docs: update home page responsive tablet

* docs: add responsive laptop screen

* docs: fix display block img

* docs: simplify css home page

* docs: clean imports and export library

* feat: upgrade to nx 19

* feat: upgrade to angular 18

* feat: migrate sidebar service to signal style

* fix: fix eslint comment

* feat: migrate alert to signal

* feat: migrate component to input style

* fix: update project.json to build

* refactor: component code

* fix: theme local storage

* feat: clean accordion component / signal service

* refactor: clean theme component's part

* refactor: add region to component's theme

* refactor: remove direct call to Flowbite varients

* feat: theme service implementation for components

* feat: add Combination type

* feat: switch from interface to type

* feat: using Combination

* feat: add [key: string]: string to component parameter types

* feat: update navbar and add navbar toggle

* refactor: clean input name and add link service

* feat: migrate input and directive to new style sys

* fix: rollback generateId in onInit

* fix: crypto is not defined

* feat: move to shiki and restyle input-field

* feat: add some documentation + update library components

* feat: add default tailwind conf for library

* refactor: new prettier and lint config

* feat: add CodeRabbit configuration

* feat: move common into shared

* refactor: update remove .tsx fils from eslint config

* feat: update badge documentation

* feat: update accordion documentation page

* feat: update alert documentation page

* feat: update breadcrumb documentation page

* feat: update button documentation page

* feat: update dropdown documentation page

* feat: update indicator documentation page

* feat: update modal documentation page

* fix(docs): clip display example

* refactor: auto close html tag

* feat(â�docs): use iframe

* feat(docs): add control panel on preview

* feat(docs): add dark mode to iframe

* feat: update breadcrumb documentation page

* feat: update button documentation page

* feat: update dropdown documentation page

* feat: update modal documentation page

* feat(docs): add size demo

* feat(docs): update frame display height

* feat(docs): get icons from flowbite-icon without size and color

* feat: update usage of icons

* feat: create IconComponent & single template file

* refactor: remove img sun

* refactor: format frame html code

* feat: update icons in frame display

* refactor: reorder class's member

* feat: use IconComponent in other components

* feat: many things after git crash lost commits :/

* docs(alert): complete alert documentation

* docs(alert): re-add dismissable alerts section

* docs: move github files to .github dir

* feat: move to structural directive for routable components

* feat: use RouterLink directive as HostDirective

* docs: add override-base-style page

* docs: fix w-full & add fragment anchor

* feat: move from aliases to colors

* feat: fix color call of config

* feat: from baseComponent to baseDirective

* feat: simplify theme files

* docs: fix customStyle

* feat: add dark and primary to colors of component

* fix: breadcrumb style

* fix: indicator offset

* feat: add sidebar-menu and add mobile support for docs

* fix(sidebar): fix autoclose on click

* fix: mobile display

* fix: mobile display

* fix(sidebar): scrollable if opened

* fix(sidebar): shrink-0

* feat(accordion): add isAlwaysOpen & clean classes

* refactor: make all inject public

* docs(accordion): add always open doc

* docs: simplify example setup

* docs(accordion): add color and flush accordion example

* feat: move baseComponent to directive

* feat: add init and verify function (see AccordionComponent)

* feat: move to inject component instead of themeServices

* docs: resize iframe for updated components

* docs: add shiki theme on components

* docs: add customStyle usage

* feat(sidebar): add RouterLinkActive to items (not binded yet on isActive in theme)

* feat(sidebar): add color and auto open if active

* feat: moe from input boolean | string to unknown

* feat: change default color to get parent's one

* feat(breadcrumb): add color support

* fix(indicator): display with text and default color

* fix: prerender error with assets not being found

* feat(navbar): add routerLinkActive like sidebar

* docs: make iframe full height

* refactor: change to anchor href for redirect

* feat(dropdown): update divider and finish doc

* feat: modal docs

* docs: added title on pages

* refactor: little fixes

* docs: add table of content

* feat: add flowbiterouterlink with href for external link

* feat(ui): Navbar layout, navbar icons and small styling changes (#50)

* feat(ui): update navbar layout

* feat(ui): add navbar icon buttons for resources

* feat(ui): change sidebar border-r colour to match figma

* feat(ui): address PR comments

* feat(ui): update ui component html

---------

Co-authored-by: MGREMY <126514209+MGREMY@users.noreply.github.com>

* feat(ui): add copy package input component (#51)

* feat(ui): update navbar layout

* feat(ui): add navbar icon buttons for resources

* feat(ui): change sidebar border-r colour to match figma

* feat(ui): address PR comments

* feat(ui): update ui component html

* feat(ui): add copy package input component

---------

Co-authored-by: MGREMY <126514209+MGREMY@users.noreply.github.com>

* docs: add sidebar documentation

* docs: add navbar documentation

* Move to new angular build executor (#52)

* fix: build

* feat: move to new application executor

* feat: config vercel

* feat: update nx

* fix: update vercel config

* fix: add env variable in vercel config

---------

Co-authored-by: GREMY Miguel <miguel.gremy@sully-group.fr>

* Move to npm package manager (#53)

* chore: move from yarn to npm

* fix: vercel npm install command

* fix: to npx command

* chore: add trigger to workflow

* fix: github ci

* fix: ci commands

* refactor: pretty files

* Full move to NgDoc library (#55)

* docs: move to ng-doc

* docs: add basic config and move landing page

* docs: full move to ng-doc

* docs: add all getting started

* docs: add customize section

* docs begin components doc

* chore: add lock file and move to npm ci

* chore: update commands & vercel config & ci config

* docs: add sidebar toggle for mobile

* docs: custom theme with custom primary color

* docs: add footer

* docs: add page processor for demo

* docs: add keyword to pages

* docs: custom ng-doc generation to fit flowbite recommendations

* docs: accordion docs moved to ng-doc

* docs: alert docs moved to ng-doc

* docs: badge docs moved to ng-doc

* docs: breadcrumb docs moved to ng-doc

* docs: button docs moved to ng-doc

* docs: dropdown docs moved to ng-doc

* docs: indicator docs moved to ng-doc

* docs: modal docs moved to ng-doc

* docs: navbar docs moved to ng-doc

* docs: sidebar docs moved to ng-doc

* docs: fix navigation bug

* docs: add subtitle on pages

* docs: clear file name when having demo component

* docs: from angular-{ts,html} to {typescript,html}

* docs: add custom header, add API page

* docs: update dependencies to fix angular keywords

* docs: update api generation

* docs: add search bar

* docs: add comments to fill the documentation

* docs: add comments in service section for the documentation

* docs: add documentation for pipes

* docs: add comments for directives and common

* fix(modal): close on route change #33 (#56)

* fix(modal): close on route change #33

* fix(modal): close on backdrop click

* fix(modal): use signal based viewChild instead of @ViewChild

* fix(modal): set z-index to 99

* fix(modal): update ModalClass to not apply any class on the host

* feat(angular): remove allowSignalWrite from component declaration

* fix(sidebar): inherit color from itemgroup/menu (it not provided) (#57)

* fix(sidebar): inherit color from itemgroup/menu (it not provided)

* fix(sidebar): remove unnecessary computed

* fix(sidebar): verify() revert back

* feat: multiple changes

BREAKING CHANGES: remove state service (except theme toggle) and switch from `input()` to `model()`

* refacto: move flowbite.theme.service and directive input/output

* refacto: remove auto call to flowbite directive and add it in template when necessary

* refacto: move every @host to host elements in @component decorator

* docs: remove padding x in landing page & add themeService for buttons in landing page

* refacto: split common types into multiple files

* chore: add public-api.ts file, preparing for segmentation with ng-packagr

* docs(navbar): add navbar example with brand, dropdown and toggle (#60)

* docs(navbar): add navbar example with brand and dropdown

inspired by flowbite-react

* docs(navbar): add example of responsive navbar

* docs(navbar): fix flowbite-navbar-brand placement

* docs(navbar): add description to responsive example

* docs(navbar): auto close if possible

* docs(docs): add base documentation

* docs(docs): update parameter table & links

* chore: remove BUILD-TOOLS.md

* fix(docs): revert `ul` and `ol` only outside of `flowbite-dropdown` #59 (#62)

fix(docs): revert `ul` and `ol` only outside of `flowbite-dropdown`

* docs(sidebar): add multi-level documentation

---------

Co-authored-by: MGREMY <mgremy.pro@gmail.com>
Co-authored-by: Ross <44373013+ross1296@users.noreply.github.com>
Co-authored-by: Bence Lovász <info@lovaszbence.hu>
@MGREMY
Copy link
Collaborator

MGREMY commented Oct 24, 2024

Hello there
The PR where the fix is located has been merged into main.
However, the fix won't be out before some time because we are currently doing some refacto on the project.. Everybody will be notified when a new version will be released (containing this fix)
As a disclaimer, there will be breaking changes in the library so.. Be prepared to change many things ;)

@MGREMY
Copy link
Collaborator

MGREMY commented Nov 4, 2024

Hey
Finally, the beta version is out (https://www.npmjs.com/package/flowbite-angular/v/1.0.0-beta.1). This issue will be fixed in the next version deployment (1.0.0)

@MGREMY
Copy link
Collaborator

MGREMY commented Nov 11, 2024

Hey there,
The 1.0.0 is out, with the fix for this bug !

@MGREMY MGREMY closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TjasaZil @YonatanToker @MGREMY