Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance and Support for Angular versions #54

Closed
tomavic opened this issue Sep 27, 2024 · 5 comments
Closed

Maintenance and Support for Angular versions #54

tomavic opened this issue Sep 27, 2024 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@tomavic
Copy link

tomavic commented Sep 27, 2024

The question is How far can you support Angular versions?

However, After checking discord and Figma I can see there are lots of work pending. This Answer to this will narrow the amount of work needed.

In addition to the work pending such as adding components, accessibility and so on, there are developer-experience-related enhancements and refactors needed.

From my side I will try to list them here, Please feel free to add yours too.

@tomavic
Copy link
Author

tomavic commented Sep 27, 2024

The first issue: No Secondary Entry Point for Components/Directives

As stated from ng-packager

Besides the primary entry point, a package can contain one or more secondary entry points (e.g. @angular/core/testing, @angular/cdk/a11y, …). These contain symbols that we don't want to group together with the symbols in the main entry point. The module id of a secondary entry directs the module loader to a sub-directory by the secondary's name.

For library developers, secondary entry points are configured by adding a ng-package.json file in subdirectories of the main package.json file's folder!

Before

Screenshot 2024-09-27 at 3 36 14 PM

After

Screenshot 2024-09-27 at 3 40 46 PM

and the library consumer will use it like this

import { SanitizeHtmlPipe } from 'flowbite-angular/pipes'

and maybe we can make it better be adding each components independently inside the src folder without need to group them (components, services, driectives) and so on.

import { Button } from 'flowbite-angular/button'

@MGREMY MGREMY added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 14, 2024
@MGREMY MGREMY self-assigned this Oct 14, 2024
@MGREMY
Copy link
Collaborator

MGREMY commented Oct 14, 2024

@tomavic Hey

We know we have plenty of work on this side. Secondary entry points are a good way to provide developers a good experience.
I think the "best way" in that case to handle it is by providing an entry point on each component/directive like that

import { ButtonComponent } from 'flowbite-angular/components/button'

In that way we will have an entry point for directive, another for component, and an entry point for each component/directive inside (as angular-material)

For now I think it's better to move this issue inside a discussion and close this issue, I'll let you create one.
Thanks for your (first) advice tho, and I'm open to some other if you have some :)

@tomavic
Copy link
Author

tomavic commented Oct 16, 2024

Hi @MGREMY
I am ready whenever you free and able to start on this change.

Thanks ;)

@MGREMY
Copy link
Collaborator

MGREMY commented Oct 16, 2024

Hey @tomavic
Are you on the flowbite's discord, I might need some help to implement a clean ng-packagr setup
So if you are on discord, send me a message ! :)

@MGREMY
Copy link
Collaborator

MGREMY commented Oct 16, 2024

(also I'm moving this into a discussion at this link)

@MGREMY MGREMY closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants