From 1a8e7b1f2c1140771ccec8c2369ff7e40ebe8441 Mon Sep 17 00:00:00 2001 From: Luca Ritossa Date: Thu, 1 Feb 2018 11:18:10 +0100 Subject: [PATCH] code refactoring for more readability and maintenance --- src/lightbox.component.ts | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/lightbox.component.ts b/src/lightbox.component.ts index 8e7d378..cce7f99 100644 --- a/src/lightbox.component.ts +++ b/src/lightbox.component.ts @@ -252,14 +252,20 @@ export class LightboxComponent implements AfterViewInit, OnDestroy { this._sizeContainer(imageWidth, imageHeight); if (this.options.centerVertically) { - var scrollOffset = this._documentRef.documentElement.scrollTop; - var viewOffset = windowHeight / 2 - imageHeight / 2; - var topDistance = scrollOffset + viewOffset; - - this._rendererRef.setElementStyle(this._lightboxElem.nativeElement, 'top', `${topDistance}px`); + this._centerVertically(imageWidth, imageHeight); } } + private _centerVertically(imageWidth: number, imageHeight: number): void { + const scrollOffset = this._documentRef.documentElement.scrollTop; + const windowHeight = this._windowRef.innerHeight; + + const viewOffset = windowHeight / 2 - imageHeight / 2; + const topDistance = scrollOffset + viewOffset; + + this._rendererRef.setElementStyle(this._lightboxElem.nativeElement, 'top', `${topDistance}px`); + } + private _sizeContainer(imageWidth: number, imageHeight: number): void { const oldWidth = this._outerContainerElem.nativeElement.offsetWidth; const oldHeight = this._outerContainerElem.nativeElement.offsetHeight;