Skip to content

Commit 56ad893

Browse files
authored
Merge pull request #289 from bburnichon/improvement/always-call-with-parambag
Always returns a ParamBag
2 parents d064765 + efb4366 commit 56ad893

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

src/Manager.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,11 @@ public function createData(ResourceInterface $resource, $scopeIdentifier = null,
9898
*
9999
* @param string $include
100100
*
101-
* @return \League\Fractal\ParamBag|null
101+
* @return \League\Fractal\ParamBag
102102
*/
103103
public function getIncludeParams($include)
104104
{
105-
if (! isset($this->includeParams[$include])) {
106-
return;
107-
}
108-
109-
$params = $this->includeParams[$include];
105+
$params = isset($this->includeParams[$include]) ? $this->includeParams[$include] : [];
110106

111107
return new ParamBag($params);
112108
}

src/TransformerAbstract.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use League\Fractal\Resource\Collection;
1515
use League\Fractal\Resource\Item;
1616
use League\Fractal\Resource\NullResource;
17-
use League\Fractal\Resource\ResourceAbstract;
17+
use League\Fractal\Resource\ResourceInterface;
1818

1919
/**
2020
* Transformer Abstract
@@ -188,13 +188,13 @@ protected function callIncludeMethod(Scope $scope, $includeName, $data)
188188
return false;
189189
}
190190

191-
if (! $resource instanceof ResourceAbstract) {
191+
if (! $resource instanceof ResourceInterface) {
192192
throw new \Exception(sprintf(
193193
'Invalid return value from %s::%s(). Expected %s, received %s.',
194194
__CLASS__,
195195
$methodName,
196-
'League\Fractal\Resource\ResourceAbstract',
197-
gettype($resource)
196+
'League\Fractal\Resource\ResourceInterface',
197+
is_object($resource) ? get_class($resource) : gettype($resource)
198198
));
199199
}
200200

0 commit comments

Comments
 (0)