Merge pull request #274 from thephpleague/feat-deprecated

Fix deprecated issues

Author: barryvdh

src/Common/CreditCard.php

@@ -377,7 +377,7 @@ public function getNumber()
     public function setNumber($value)
     {
         // strip non-numeric characters
-        return $this->setParameter('number', preg_replace('/\D/', '', $value));
+        return $this->setParameter('number', preg_replace('/\D/', '', (string) $value));
     }
 
     /**
@@ -412,8 +412,10 @@ public function getNumberMasked($mask = 'X')
      */
     public function getBrand()
     {
+        $number = (string) $this->getNumber();
+
         foreach ($this->getSupportedBrands() as $brand => $val) {
-            if (preg_match($val, $this->getNumber())) {
+            if (preg_match($val, $number)) {
                 return $brand;
             }
         }

src/Common/Helper.php

@@ -63,7 +63,7 @@ protected static function convertToLowercase($str)
     public static function validateLuhn($number)
     {
         $str = '';
-        foreach (array_reverse(str_split($number)) as $i => $c) {
+        foreach (array_reverse(str_split((string) $number)) as $i => $c) {
             $str .= $i % 2 ? $c * 2 : $c;
         }
 

src/Common/Message/AbstractResponse.php

@@ -215,7 +215,7 @@ public function getRedirectResponse()
             $hiddenFields .= sprintf(
                 '<input type="hidden" name="%1$s" value="%2$s" />',
                 htmlentities($key, ENT_QUOTES, 'UTF-8', false),
-                htmlentities($value, ENT_QUOTES, 'UTF-8', false)
+                htmlentities((string) $value, ENT_QUOTES, 'UTF-8', false)
             )."\n";
         }
 

tests/Common/GatewayFactoryTest.php

@@ -7,6 +7,9 @@
 
 class GatewayFactoryTest extends TestCase
 {
+    /** @var GatewayFactory  */
+    protected $factory;
+
     public static function setUpBeforeClass() : void
     {
         m::mock('alias:Omnipay\\SpareChange\\TestGateway');

tests/Common/ItemBagTest.php

@@ -6,6 +6,9 @@
 
 class ItemBagTest extends TestCase
 {
+    /** @var ItemBag  */
+    protected $bag;
+
     public function setUp() : void
     {
         $this->bag = new ItemBag;

tests/Common/ItemTest.php

@@ -6,6 +6,9 @@
 
 class ItemTest extends TestCase
 {
+    /** @var Item  */
+    protected $item;
+
     public function setUp() : void
     {
         $this->item = new Item;