Skip to content

Commit d36532d

Browse files
authored
Merge pull request #33 from theredditbandit/dev
fix bug in ReadREADME function
2 parents 6277a63 + dcb1cef commit d36532d

File tree

3 files changed

+20
-10
lines changed

3 files changed

+20
-10
lines changed

cmd/ls.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var lsCmd = &cobra.Command{
1818
`,
1919
RunE: func(cmd *cobra.Command, _ []string) error {
2020
filterFlag, _ := cmd.Flags().GetString("f")
21-
oldUI, _ := cmd.Flags().GetBool("o")
21+
oldUI, _ := cmd.Flags().GetBool("c")
2222
data, err := db.GetAllRecords(db.DBName, StatusBucket)
2323
if err != nil {
2424
return err
@@ -37,5 +37,5 @@ var lsCmd = &cobra.Command{
3737
func init() {
3838
rootCmd.AddCommand(lsCmd)
3939
lsCmd.Flags().String("f", "", "Filter projects by status. Usage : pman ls --f <status>")
40-
lsCmd.Flags().Bool("o", false, "list projects using the old ui. Usage : pman ls --o")
40+
lsCmd.Flags().Bool("c", false, "list projects using the colorful table. Usage : pman ls --c")
4141
}

pkg/ui/interactiveTable.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@ package ui
33
import (
44
"fmt"
55
"sort"
6+
"strings"
67

78
"github.com/charmbracelet/bubbles/table"
89
tea "github.com/charmbracelet/bubbletea"
910
"github.com/charmbracelet/lipgloss"
1011

1112
"github.com/theredditbandit/pman/pkg"
1213
"github.com/theredditbandit/pman/pkg/db"
13-
p "github.com/theredditbandit/pman/pkg/ui/pager"
14+
pgr "github.com/theredditbandit/pman/pkg/ui/pager"
1415
"github.com/theredditbandit/pman/pkg/utils"
1516
)
1617

@@ -38,7 +39,11 @@ func (m tableModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
3839
return m, tea.Quit
3940
case "enter":
4041
project := m.table.SelectedRow()[1]
41-
err := p.LaunchRenderer(project)
42+
if strings.Contains(project, ")") { // project is of the form a-long-project-name (alias)
43+
projectAliasArr := strings.Split(project, " ")
44+
project = projectAliasArr[0]
45+
}
46+
err := pgr.LaunchRenderer(project)
4247
if err != nil {
4348
return m, tea.Quit
4449
}

pkg/utils/utils.go

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,14 +96,19 @@ func BeautifyMD(data []byte) (string, error) {
9696

9797
// ReadREADME: returns the byte array of README.md of a project
9898
func ReadREADME(projectName string) ([]byte, error) {
99-
actualName, err := db.GetRecord(db.DBName, projectName, pkg.ProjectAliasBucket)
100-
if err == nil {
101-
projectName = actualName
102-
}
10399
path, err := db.GetRecord(db.DBName, projectName, pkg.ProjectPaths)
104100
if err != nil {
105-
log.Printf("project: %v not a valid project\n", projectName)
106-
return nil, errors.Join(ErrReadREADME, err)
101+
actualName, err := db.GetRecord(db.DBName, projectName, pkg.ProjectAliasBucket)
102+
if err != nil {
103+
log.Printf("project: %v not a valid project\n", projectName)
104+
return nil, errors.Join(ErrReadREADME, err)
105+
}
106+
projectName = actualName
107+
path, err = db.GetRecord(db.DBName, projectName, pkg.ProjectPaths)
108+
if err != nil {
109+
log.Printf("project: %v not a valid project\n", projectName)
110+
return nil, errors.Join(ErrReadREADME, err)
111+
}
107112
}
108113
pPath := filepath.Join(path, "README.md")
109114
data, err := os.ReadFile(pPath)

0 commit comments

Comments
 (0)