Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme variables not cascading into presentation components #69

Closed
1 of 5 tasks
thescientist13 opened this issue Nov 12, 2023 · 0 comments · Fixed by #70
Closed
1 of 5 tasks

theme variables not cascading into presentation components #69

thescientist13 opened this issue Nov 12, 2023 · 0 comments · Fixed by #70
Assignees
Labels
0.8.1 bug Something isn't working documentation Improvements or additions to documentation question Further information is requested

Comments

@thescientist13
Copy link
Owner

thescientist13 commented Nov 12, 2023

Type of Change

  • New Feature Request
  • Documentation
  • Improvement / Suggestion
  • Bug (regression)
  • Other (please clarify below)

Summary

Looks like in the push to remove deps in #67 , seems like we still need the import-css plugin. Noticed that there was a flickering when changing slides in a project

Screen.Recording.2023-11-12.at.1.33.27.PM.mov

and was able to confirm that the variable setting the iframe background color does not register now
Screenshot 2023-11-12 at 1 34 19 PM

Details

This is related to this change specifically. I incorrectly assumed :host would pierce the shadow, and it does not. hardcoding the style into the Shadow DOM confirmed restoration of the background color

Screen.Recording.2023-11-12.at.1.35.30.PM.mov

Screenshot 2023-11-12 at 1 35 22 PM


So likely we will need to re-introduce that plugin as a dependency and part of the setup steps. Not sure to push this out as a patch or semver minor though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.8.1 bug Something isn't working documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
1 participant