From 46d51e8bb3e5ee8e0578dff5fef0b5bbd0427ddb Mon Sep 17 00:00:00 2001 From: Kevin Boos <1139460+kevinaboos@users.noreply.github.com> Date: Sat, 23 Sep 2023 23:40:56 -0700 Subject: [PATCH] clarify pending x86 impl of SystemWideInterruptController (ioapic) --- kernel/interrupt_controller/src/x86_64.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/interrupt_controller/src/x86_64.rs b/kernel/interrupt_controller/src/x86_64.rs index 2e8de20c04..adbee306eb 100644 --- a/kernel/interrupt_controller/src/x86_64.rs +++ b/kernel/interrupt_controller/src/x86_64.rs @@ -64,9 +64,9 @@ impl SystemInterruptControllerApi for SystemInterruptController { let _ = priority; if let Some(destination) = destination { - int_ctlr.set_irq(sys_int_num, destination.into(), sys_int_num /* <- is this correct? */) + int_ctlr.set_irq(sys_int_num, destination.into(), sys_int_num) } else { - Err("SystemInterruptController::set_destination: todo on x86") + Err("SystemInterruptController::set_destination: todo on x86: set the IOREDTBL MASK bit") } } }