Rename JobHooks to JobSideEffects

Author: gregorbg

app/jobs/registration_processor.rb

@@ -7,25 +7,25 @@ class RegistrationProcessor < ApplicationJob
 
   def perform(message)
     Rails.logger.debug { "Working on Message: #{message}" }
-    hooks = JobHooks.new
+    side_effects = JobSideEffects.new
     if message[:step] == 'EventRegistration'
       event_registration(message[:competition_id],
                          message[:user_id],
                          message[:step_details][:event_ids],
                          message[:step_details][:comment],
                          message[:step_details][:guests],
                          message[:created_at],
-                         hooks)
+                         side_effects)
     end
     Rails.cache.delete("#{message[:user_id]}-registrations-by-user")
-    hooks.run(:after_processing)
+    side_effects.run(:after_processing)
     Metrics.increment('registrations_processed')
   end
 
   private
 
     # rubocop:disable Metrics/ParameterLists
-    def event_registration(competition_id, user_id, event_ids, comment, guests, created_at, hooks)
+    def event_registration(competition_id, user_id, event_ids, comment, guests, created_at, side_effects)
       # Event Registration might not be the first lane that is completed
       # TODO: When we add another lane, we need to update the registration history instead of creating it
       registration = begin
@@ -49,7 +49,7 @@ def event_registration(competition_id, user_id, event_ids, comment, guests, crea
       else
         registration.update_attributes(lanes: registration.lanes.append(competing_lane), guests: guests)
       end
-      hooks.after_processing do
+      side_effects.after_processing do
         EmailApi.send_creation_email(competition_id, user_id)
       end
     end

lib/job_hooks.rb renamed to lib/job_side_effects.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class JobHooks
+class JobSideEffects
   attr_writer :after_processing
 
   def initialize