This repository has been archived by the owner on Jan 3, 2025. It is now read-only.
Refactor Registration Admin selected-rows reducer #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canChangeStatuses still needs to be properly defined.
|
I finished it by adding a isOrganizerOrDelegate to the PermissionsContext |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids storing redundant information in state about which table the selected attendee is in. This technically wasn't causing issues, but future code changes had the possibility of introducing bugs.
Also changed the checkboxes on the header rows to match the state of the rows below (ie is checked if and only if all the rows are checked), and omitted them when their respective table is empty.
Plus I started adding the functionality to hide the changing-status buttons when the user doesn't have that ability - @FinnIckler if you could finish that off that would be great, since you're familiar with who should have what permissions. Or it can be saved for a later ticket.