TbStorage interface changed incorrectly

[Jon-Salmon]

In commit 778f426 the TbStorage interface changed (seemingly to add support for non-string values). As a result of this change, the getItem field is no longer marked as returning a Future. As far as I can see, the value is still used to return futures in various instances (see _local_file_storage.dart), but as it stands the compiler/linter won't raise any errors if the use of this value isn't awaited in when used. I believe the interface should be updated/reverted to:

Future<E?> getItem(String key, {E? defaultValue});

[benoit-rolandeau-act]

Agree. Moreover, when we want to use external package such as flutter_secure_storage their load method is asynchronous; therefore, be asynchronous opens more possibility.

[benoit-rolandeau-act]

I opened a PR to fix this: #57

[ybeshkarov]

I've changed it 00bb312

[benoit-rolandeau-act]

@ybeshkarov there is an error on your modification, you write:

Future<E>? getItem(String key, {E? defaultValue});

But we expect the element to be:

- Future<E>? getItem(String key, {E? defaultValue});
+ Future<E?> getItem(String key, {E? defaultValue});

The nullable is not in the right place.

[benoit-rolandeau-act]

I have created a PR to fix it: #59