-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edittor Settings in XML while exporting Entity as Source Control #43
Comments
This would actually be a great improvement. The current implementation was a quick PoC to prove that this functionality can be implemented, but it was never improved, so it faces a few issues:
Your implementation could work around issues 1. and 2., while opening the door to fixing 3. as well. Here's some points I think would improve it even more:
I would gladly accept a PR with this functionality. Thanks a lot in the interest of using this extension. |
@stefan-lacatus About Undo/Redo stack I have a few doubts. How would you resolve the problem of working on the same code with more than 1 person at the same time? Saving this stack in XML would be for sure bad, but I am not sure if |
This is also quite not ok IMHO. I would assume that |
you are 100% correct on that. Completely forgot about the service name What about P.S. I call it method name because subscriptions also must work, and MethodName fits both "serviceName" and "subscriptionName" |
We can merge this in multiple steps, with multiple PRs:
|
Hi!
Great job about this editor! During early tests, I found out that info about the view state is being kept in the Entity object itself. That is causing an issue with keeping that metadata in XML while exporting to source control entities.
Normally I would not expect to keep that metadata persistent. I see the value of keeping it during development, but not permanently.
I've developed a quick alternative with
sessionStorage
and it works perfectly fine. Metadata is stored there temporarily when Tab is open. Each service will have its own key-value pair:Let me know if you are interested in having it in your codebase. Can do a fork and PR later on.
The text was updated successfully, but these errors were encountered: