Skip to content

Commit 577504b

Browse files
authored
Some fixes (#1722)
1 parent d45ee3f commit 577504b

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

src/LocalField/LocalField.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ elem_type(::Type{LocalField{S, T}}) where {S <: FieldElem, T <: LocalFieldParame
4747
#
4848
################################################################################
4949

50-
is_domain_type(::Type{S}) where S <: LocalField = true
51-
is_exact_type(::Type{S}) where S <: LocalField = false
50+
is_domain_type(::Type{<: LocalFieldElem}) = true
51+
is_exact_type(::Type{<: LocalFieldElem}) = false
5252
isfinite(K::LocalField) = isfinite(base_field(K))
5353

5454
################################################################################

src/Misc/RelFiniteField.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,8 @@ iszero(x::RelFinFieldElem) = iszero(x.data)
141141
isone(x::RelFinFieldElem) = isone(x.data)
142142
is_unit(x::RelFinFieldElem) = !iszero(x)
143143

144+
hash(x::RelFinFieldElem, h::UInt) = hash(x.data, h)
145+
144146
==(x::RelFinFieldElem{S, T}, y::RelFinFieldElem{S, T}) where {S, T} = x.data == y.data
145147

146148
coeff(a::RelFinFieldElem, i::Int) = coeff(a.data, i)

src/NumField/Embedded.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ base_ring_type(::Type{<:EmbeddedNumField}) = QQField
6565

6666
data(x::EmbeddedNumFieldElem) = x.element
6767

68+
characteristic(::EmbeddedNumField) = 0
69+
6870
function embedded_field(K::SimpleNumField, i::NumFieldEmb)
6971
@assert number_field(i) === K
7072
E = EmbeddedNumField(K, i)

0 commit comments

Comments
 (0)