fix equality for ZZGenus and do not copy symbols #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevellM
reviewed
Dec 19, 2023
|
I know where the code is breaking in Oscar, I can make a short PR so that CI tests hopefully do not fail |
lgoettgens
reviewed
Dec 19, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
+ Coverage 74.66% 74.68% +0.02%
==========================================
Files 346 346
Lines 112094 112088 -6
==========================================
+ Hits 83692 83718 +26
+ Misses 28402 28370 -32
|
|
I just restarted the Oscar tests, and they are still failing. Any clue @StevellM? |
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
thofma
force-pushed
the
sb/fix_genus_equality
branch
from
26e6594 to
8e4640f
Compare
|
Yes after testing it seems like |
|
Merci, I restarted CI |
thofma
pushed a commit
that referenced
this pull request
Jan 5, 2024
* fix equality for ZZGenus and do not copy symbols --------- Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com> Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.