-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Miscellany Classes to avoid conflict with Core Nodes #14
Comments
Referred to this documentation for setting up a migrations file or node name changes: https://github.com/DynamoDS/Dynamo/wiki/Zero-Touch-Plugin-Development#migrations |
Others have changed their class names to plural to avoid this |
I have tried various options and the least troublesome seems to be to rename classes to avoid conflict. In this first example I have focused on the geometry nodes. Instead of having a CoodinateSystem class I have amalgamated it into one Abstract class with methods named CoordinateSystemDisplay
becomes
The downside is that the node goes from the simple name (and consistent with core Dynamo nodes) of CoordinateSystem.Display to Abstract.CoordinateSystemDisplay but I think that is the price that has to be paid to avoid class name conflicts and also names like CoordinateSystems.Display or MiscCoordinateSystem.Display I have also added DynamoVisualProgramming.Core to the solution and used
to reclassify those nodes from actions (⚡) to query (?) Initial commit: 0872d64 |
I have completed the review of class names with the following amendments.
The slight lack of consistency in naming is unfortunate but it will avoid conflicts with core nodes or other packages until a proper solution is implemented in Dynamo itself |
Spoke to Keith Alfaro at the London Dynamo + Generative Design Hackathon 2019 and he confirmed that you need to avoid using the same class names |
Having the same class names as Core Nodes leads to warnings and clashes when using in DesignScript.
Although it can be ignored it would be better have different names and use the Miscellany_DynamoCustomization.xml to categorize in the listThe text was updated successfully, but these errors were encountered: