Fix #307

thomasp85 · thomasp85 · commit bdb7e39afb9e · 2024-01-18T08:59:47.000+01:00
diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,8 @@
 * The concaveman package is no longer a dependency for `geom_mark_hull()` (#308)
 * Setting both label and description to `NA` will now turn off label drawing for
   that mark completely while still drawing the mark
+* Fix a bug in `geom_mark_rect()` where the mark would not be shown in all 
+  panels (#307)
 
 # ggforce 0.4.1
 
diff --git a/R/mark_rect.R b/R/mark_rect.R
@@ -79,7 +79,7 @@ GeomMarkRect <- ggproto('GeomMarkRect', GeomMarkCircle,
       data <- data[data$filter, ]
     }
     if (nrow(data) == 0) return(data)
-    vec_rbind(!!!lapply(split(data, data$group), function(d) {
+    vec_rbind(!!!lapply(split(data, list(data$PANEL, data$group)), function(d) {
       if (nrow(d) == 1) return(d)
       x_range <- range(d$x, na.rm = TRUE)
       y_range <- range(d$y, na.rm = TRUE)

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ GeomMarkRect <- ggproto('GeomMarkRect', GeomMarkCircle,`
`79`	`79`	`data <- data[data$filter, ]`
`80`	`80`	`}`
`81`	`81`	`if (nrow(data) == 0) return(data)`
`82`		`- vec_rbind(!!!lapply(split(data, data$group), function(d) {`
	`82`	`+ vec_rbind(!!!lapply(split(data, list(data$PANEL, data$group)), function(d) {`
`83`	`83`	`if (nrow(d) == 1) return(d)`
`84`	`84`	`x_range <- range(d$x, na.rm = TRUE)`
`85`	`85`	`y_range <- range(d$y, na.rm = TRUE)`