Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link to the vignette #158

Closed
matteodefelice opened this issue Aug 10, 2019 · 7 comments
Closed

Broken link to the vignette #158

matteodefelice opened this issue Aug 10, 2019 · 7 comments

Comments

@matteodefelice
Copy link

Both on github and on the official website the link to the vignette is broken.

@bbolker
Copy link

bbolker commented Aug 21, 2019

I can see from the NEWS file that: "Removed the Visual Guide vignette to reduce compilation time. See the website for an overview of all functionality with compiled examples (https://ggforce.data-imaginist.com)" - but the web page still directs us to the vignette, as @matteodefelice points out. Perhaps as an interim measure the vignette source could go somewhere in inst so we can access it via system.file() ?

(For anyone else who's looking, you can find the source here ...)

@thomasp85
Copy link
Owner

The link has been changed as the vignette has been removed. It was only ever necessary when there wasn’t a webpage with examples and added a lot of time to check and build times

@bbolker
Copy link

bbolker commented Aug 24, 2019

I guess the point is that the web page presented doesn't seem to have many examples.

This website says

The package has a website where every feature is described and justified with examples and plots.

now the "website" link goes right back to https://ggforce.data-imaginist.com/ , which seems to be just the same as the README file. Is there in fact a web page somewhere with examples?

@thomasp85
Copy link
Owner

Yeah, well the front page of the website is just the readme so following the link from the website is a bit circular... the webpage contains documentation for all functions along with compiled example code — don’t know what else you’d expect?

@bbolker
Copy link

bbolker commented Aug 24, 2019

OK, I guess I didn't see the "Reference" drop-down. Sorry to bother you. Maybe, for idiots like me, add a sentence that says "see the 'Reference' tab at the top of the page for a complete list of functions in the package, along with documentation and examples."

@thomasp85
Copy link
Owner

Sure, I guess it could be better worded🙂

@DanChaltiel
Copy link

For people like me who like articles/vignettes, you can find the old one on http://cran.nexr.com/web/packages/ggforce/vignettes/Visual_Guide.html (hoping it is not too outdated)

@thomasp85 Looking in Reference does not feel the same: in the vignette, I can see all the functions and their output without having to navigate through many redundant pages. If the compilation time is less of an issue than it was five years ago, maybe you can reconsider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants