Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support exporter metadata in Android provider #2944

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

thomaspoignant
Copy link
Owner

Description

Support exporter metadata in Android provider

Closes issue(s)

Resolve #2941

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 440b7b0
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/67877727c839d70009d12e84

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (dfe49ed) to head (440b7b0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2944   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files         113      113           
  Lines        5239     5239           
=======================================
  Hits         4439     4439           
  Misses        634      634           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@thomaspoignant
Copy link
Owner Author

CI is failing as usual in the Kotlin CI

@thomaspoignant thomaspoignant merged commit 6ce4960 into main Jan 16, 2025
22 of 24 checks passed
@thomaspoignant thomaspoignant deleted the exporter-metadata-android branch January 16, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Support exporter metadata Android
1 participant