Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump kubernetes version for common image #1254

Merged
merged 1 commit into from
Apr 28, 2022
Merged

bump kubernetes version for common image #1254

merged 1 commit into from
Apr 28, 2022

Conversation

Gregory-Pereira
Copy link
Member

@Gregory-Pereira Gregory-Pereira commented Apr 11, 2022 •
edited by fridex
Loading

Related Issues and Dependencies

Fixes: #1251

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Bumping version of PyYaml (which depends on Kubernetes, which depends on openshift) for CVE_2020_1747

@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2022
fridex
fridex reviewed Apr 11, 2022
View reviewed changes
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth checking if this will work. We have pinned the version because of some incompatibilities (it could be recorded in the history).

@Gregory-Pereira Gregory-Pereira force-pushed the bump_kubernetes_module_for_cve_2020_1747 branch 3 times, most recently from 22b467d to 960039d Compare April 11, 2022 19:33
harshad16
harshad16 requested changes Apr 12, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert pre-commit chnages

@Gregory-Pereira Gregory-Pereira force-pushed the bump_kubernetes_module_for_cve_2020_1747 branch from 960039d to 8343d2e Compare April 12, 2022 16:59
@Gregory-Pereira Gregory-Pereira force-pushed the bump_kubernetes_module_for_cve_2020_1747 branch from 8343d2e to a93ecc8 Compare April 21, 2022 22:14
@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 21, 2022
harshad16
harshad16 requested changes Apr 25, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All lgtm
can you please rebase your PR that would get to 1 commit
and also one suggestion.

Pipfile Outdated Show resolved Hide resolved
@Gregory-Pereira Gregory-Pereira force-pushed the bump_kubernetes_module_for_cve_2020_1747 branch 2 times, most recently from c04d715 to a93ecc8 Compare April 25, 2022 16:56
@sesheta sesheta added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2022
@Gregory-Pereira Gregory-Pereira force-pushed the bump_kubernetes_module_for_cve_2020_1747 branch from a93ecc8 to d1660dd Compare April 25, 2022 16:57
@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 26, 2022
@Gregory-Pereira Gregory-Pereira force-pushed the bump_kubernetes_module_for_cve_2020_1747 branch from b308ea4 to ddfacec Compare April 26, 2022 18:18
@sesheta sesheta added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2022
@Gregory-Pereira Gregory-Pereira force-pushed the bump_kubernetes_module_for_cve_2020_1747 branch from ddfacec to 705896e Compare April 26, 2022 18:58
@Gregory-Pereira Gregory-Pereira force-pushed the bump_kubernetes_module_for_cve_2020_1747 branch from 705896e to 898a361 Compare April 26, 2022 19:00
@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 26, 2022
harshad16
harshad16 reviewed Apr 28, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks 💯

PTAL @fridex

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2022
fridex
fridex approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I've also tried to verify that the common library is still able to schedule workfload in the cluster. No issues observed, but we should keep an eye on this change. 👍🏻

@sesheta
Copy link
Member

sesheta commented Apr 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2022
@sesheta sesheta merged commit 2d65951 into thoth-station:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 requested changes

@fridex fridex fridex approved these changes

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubernetes module version 11.0.0 has CVE
4 participants
@Gregory-Pereira @sesheta @fridex @harshad16