From fe7df352df89768ba539a980cb947740cdbb2b4d Mon Sep 17 00:00:00 2001 From: Xander Garbett Date: Sat, 6 Jan 2024 16:09:06 +0000 Subject: [PATCH] Silence linter, add comments on _why_ the go.mods are needed --- .golangci.yml | 1 + go.mod | 4 ++-- third_party/go/BUILD | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index e07e66c5..52364ac2 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -11,6 +11,7 @@ issues: - SA5008 # Warns for duplicate struct tags which are meaningful to go-flags - unslice # This may be useful in some places. - ifElseChain # Generally don't agree. + - indent-error-flow # Similar to above, seems to be making questionable choices - appendAssign - halp # Make misspell be quiet about this. - exitAfterDefer # Potentially useful but not in any cases it fires right now. diff --git a/go.mod b/go.mod index 969059f8..e70631fe 100644 --- a/go.mod +++ b/go.mod @@ -28,8 +28,8 @@ require ( github.com/thought-machine/http-admin v1.1.0 go.uber.org/automaxprocs v1.5.3 gocloud.dev v0.36.0 - github.com/golang/snappy v0.0.4 // indirect - github.com/google/go-cmp v0.6.0 // indirect + github.com/golang/snappy v0.0.4 // This is a required dep that Go mod tidy gets rid of. This breaks Please if it gets removed though. + github.com/google/go-cmp v0.6.0 // This is a required dep that Go mod tidy gets rid of. This breaks Please if it gets removed though. golang.org/x/crypto v0.17.0 golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc golang.org/x/sync v0.6.0 diff --git a/third_party/go/BUILD b/third_party/go/BUILD index 703e5eeb..6844e96f 100644 --- a/third_party/go/BUILD +++ b/third_party/go/BUILD @@ -1356,7 +1356,7 @@ go_repo( go_repo( module = "github.com/bazelbuild/remote-apis", - version = "v0.0.0-20231221155620-d20ae8b97fd3", + version = "v0.0.0-20230411132548-35aee1c4a425", ) go_repo( @@ -3823,7 +3823,7 @@ go_repo( go_mod_download( name = "remote-apis-sdks_download", module = "github.com/peterebden/remote-apis-sdks", - version = "2a9420921957c3485fc59c6cae6adc849591ba48", + version = "v0.0.0-20230518122452-6e5d9d252ff0", ) go_repo(