From 9025e70e5c986220903c54a656229832bd555fcd Mon Sep 17 00:00:00 2001 From: Nathan Bierema Date: Thu, 30 Nov 2023 14:03:09 -0500 Subject: [PATCH] Add `| undefined` where appropriate --- types/three/examples/jsm/helpers/TextureHelper.d.ts | 2 +- types/three/examples/jsm/math/Octree.d.ts | 4 ++-- .../three/examples/jsm/postprocessing/HBAOPass.d.ts | 2 +- .../examples/jsm/renderers/common/Renderer.d.ts | 2 +- types/three/examples/jsm/utils/SortUtils.d.ts | 8 ++++---- types/three/src/objects/BatchedMesh.d.ts | 13 +++++++++++-- types/three/src/renderers/WebGL1Renderer.d.ts | 2 +- types/three/src/renderers/WebGL3DRenderTarget.d.ts | 7 ++++++- .../three/src/renderers/WebGLArrayRenderTarget.d.ts | 7 ++++++- .../three/src/renderers/WebGLCubeRenderTarget.d.ts | 2 +- .../src/renderers/WebGLMultipleRenderTargets.d.ts | 7 ++++++- types/three/src/renderers/WebGLRenderTarget.d.ts | 6 +++++- types/three/src/renderers/WebGLRenderer.d.ts | 2 +- 13 files changed, 46 insertions(+), 18 deletions(-) diff --git a/types/three/examples/jsm/helpers/TextureHelper.d.ts b/types/three/examples/jsm/helpers/TextureHelper.d.ts index ba0c9fb53..33561d849 100644 --- a/types/three/examples/jsm/helpers/TextureHelper.d.ts +++ b/types/three/examples/jsm/helpers/TextureHelper.d.ts @@ -4,7 +4,7 @@ export class TextureHelper extends Mesh { texture: Texture; type: 'TextureHelper'; - constructor(texture: Texture, width?: number, height?: number, depth?: number); + constructor(texture: Texture, width?: number | undefined, height?: number | undefined, depth?: number | undefined); dispose(): void; } diff --git a/types/three/examples/jsm/math/Octree.d.ts b/types/three/examples/jsm/math/Octree.d.ts index b733a045a..e7797212d 100644 --- a/types/three/examples/jsm/math/Octree.d.ts +++ b/types/three/examples/jsm/math/Octree.d.ts @@ -3,13 +3,13 @@ import { Triangle, Box3, Ray, Sphere, Object3D } from '../../../src/Three.js'; import { Capsule } from './Capsule.js'; export class Octree { - box: Box3; + box: Box3 | null | undefined; bounds: Box3; subTrees: Octree[]; triangles: Triangle[]; - constructor(box?: Box3); + constructor(box?: Box3 | null | undefined); addTriangle(triangle: Triangle): this; calcBox(): this; diff --git a/types/three/examples/jsm/postprocessing/HBAOPass.d.ts b/types/three/examples/jsm/postprocessing/HBAOPass.d.ts index 288cf0df6..bdf496e1d 100644 --- a/types/three/examples/jsm/postprocessing/HBAOPass.d.ts +++ b/types/three/examples/jsm/postprocessing/HBAOPass.d.ts @@ -93,7 +93,7 @@ export class HBAOPass extends Pass { restoreVisibility(): void; - generateNoise(size?: number): DataTexture; + generateNoise(size?: number | undefined): DataTexture; static OUTPUT: { Default: 0; diff --git a/types/three/examples/jsm/renderers/common/Renderer.d.ts b/types/three/examples/jsm/renderers/common/Renderer.d.ts index b4e93840f..bfe19171c 100644 --- a/types/three/examples/jsm/renderers/common/Renderer.d.ts +++ b/types/three/examples/jsm/renderers/common/Renderer.d.ts @@ -26,7 +26,7 @@ export default class Renderer { info: Info; - constructor(backend: Backend, parameters?: { logarithmicDepthBuffer?: boolean }); + constructor(backend: Backend, parameters?: { logarithmicDepthBuffer?: boolean | undefined } | undefined); init(): Promise; diff --git a/types/three/examples/jsm/utils/SortUtils.d.ts b/types/three/examples/jsm/utils/SortUtils.d.ts index 9aa2697c3..06f65453b 100644 --- a/types/three/examples/jsm/utils/SortUtils.d.ts +++ b/types/three/examples/jsm/utils/SortUtils.d.ts @@ -1,7 +1,7 @@ export interface RadixSortOptions { - aux?: T[]; - get?: (el: T) => number; - reversed?: boolean; + aux?: T[] | undefined; + get?: ((el: T) => number) | undefined; + reversed?: boolean | undefined; } -export const radixSort: (arr: T[], opt?: RadixSortOptions) => void; +export const radixSort: (arr: T[], opt?: RadixSortOptions | undefined) => void; diff --git a/types/three/src/objects/BatchedMesh.d.ts b/types/three/src/objects/BatchedMesh.d.ts index 24c686a8a..97bb0ae1f 100644 --- a/types/three/src/objects/BatchedMesh.d.ts +++ b/types/three/src/objects/BatchedMesh.d.ts @@ -81,7 +81,12 @@ declare class BatchedMesh extends Mesh { * @param maxIndexCount the max number of indices to be used by all geometries. * @param material an instance of [page:Material]. Default is a new {@link MeshBasicMaterial}. */ - constructor(maxGeometryCount: number, maxVertexCount: number, maxIndexCount?: number, material?: Material); + constructor( + maxGeometryCount: number, + maxVertexCount: number, + maxIndexCount?: number | undefined, + material?: Material | undefined, + ); /** * Computes the bounding box, updating {@link .boundingBox} attribute. @@ -147,7 +152,11 @@ declare class BatchedMesh extends Mesh { * geometry. This is necessary if it is planned to set a new geometry at this index at a later time that is larger * than the original geometry. Defaults to the length of the given geometry index buffer. */ - addGeometry(geometry: BufferGeometry, reservedVertexRange?: number, reservedIndexRange?: number): number; + addGeometry( + geometry: BufferGeometry, + reservedVertexRange?: number | undefined, + reservedIndexRange?: number | undefined, + ): number; /** * Replaces the geometry at `index` with the provided geometry. Throws an error if there is not enough space diff --git a/types/three/src/renderers/WebGL1Renderer.d.ts b/types/three/src/renderers/WebGL1Renderer.d.ts index b1f3b46ac..f1d498c32 100644 --- a/types/three/src/renderers/WebGL1Renderer.d.ts +++ b/types/three/src/renderers/WebGL1Renderer.d.ts @@ -1,6 +1,6 @@ import { WebGLRenderer, WebGLRendererParameters } from './WebGLRenderer.js'; export class WebGL1Renderer extends WebGLRenderer { - constructor(parameters?: WebGLRendererParameters); + constructor(parameters?: WebGLRendererParameters | undefined); readonly isWebGL1Renderer: true; } diff --git a/types/three/src/renderers/WebGL3DRenderTarget.d.ts b/types/three/src/renderers/WebGL3DRenderTarget.d.ts index 18406ad9e..7f40ca4fe 100644 --- a/types/three/src/renderers/WebGL3DRenderTarget.d.ts +++ b/types/three/src/renderers/WebGL3DRenderTarget.d.ts @@ -14,7 +14,12 @@ export class WebGL3DRenderTarget extends WebGLRenderTarget { * @param options optional object that holds texture parameters for an auto-generated target texture and * depthBuffer/stencilBuffer booleans. See {@link WebGLRenderTarget} for details. */ - constructor(width?: number, height?: number, depth?: number, options?: WebGLRenderTargetOptions); + constructor( + width?: number | undefined, + height?: number | undefined, + depth?: number | undefined, + options?: WebGLRenderTargetOptions | undefined, + ); /** * The depth of the render target. diff --git a/types/three/src/renderers/WebGLArrayRenderTarget.d.ts b/types/three/src/renderers/WebGLArrayRenderTarget.d.ts index e453af468..e703820fa 100644 --- a/types/three/src/renderers/WebGLArrayRenderTarget.d.ts +++ b/types/three/src/renderers/WebGLArrayRenderTarget.d.ts @@ -14,7 +14,12 @@ export class WebGLArrayRenderTarget extends WebGLRenderTarget { * @param options optional object that holds texture parameters for an auto-generated target texture and * depthBuffer/stencilBuffer booleans. See {@link WebGLRenderTarget} for details. */ - constructor(width?: number, height?: number, depth?: number, options?: WebGLRenderTargetOptions); + constructor( + width?: number | undefined, + height?: number | undefined, + depth?: number | undefined, + options?: WebGLRenderTargetOptions | undefined, + ); /** * The depth of the render target. diff --git a/types/three/src/renderers/WebGLCubeRenderTarget.d.ts b/types/three/src/renderers/WebGLCubeRenderTarget.d.ts index 23e36e5fd..71d049915 100644 --- a/types/three/src/renderers/WebGLCubeRenderTarget.d.ts +++ b/types/three/src/renderers/WebGLCubeRenderTarget.d.ts @@ -4,7 +4,7 @@ import { Texture } from '../textures/Texture.js'; import { CubeTexture } from '../textures/CubeTexture.js'; export class WebGLCubeRenderTarget extends WebGLRenderTarget { - constructor(size?: number, options?: WebGLRenderTargetOptions); + constructor(size?: number | undefined, options?: WebGLRenderTargetOptions | undefined); texture: CubeTexture; diff --git a/types/three/src/renderers/WebGLMultipleRenderTargets.d.ts b/types/three/src/renderers/WebGLMultipleRenderTargets.d.ts index 8aad96053..b28d0c467 100644 --- a/types/three/src/renderers/WebGLMultipleRenderTargets.d.ts +++ b/types/three/src/renderers/WebGLMultipleRenderTargets.d.ts @@ -9,7 +9,12 @@ export class WebGLMultipleRenderTargets extends WebGLRenderTarget { * @param options object that holds texture parameters for an auto-generated target texture and depthBuffer/stencilBuffer booleans. * For an explanation of the texture parameters see {@link Texture}. */ - constructor(width?: number, height?: number, count?: number, options?: WebGLRenderTargetOptions); + constructor( + width?: number | undefined, + height?: number | undefined, + count?: number | undefined, + options?: WebGLRenderTargetOptions | undefined, + ); readonly isWebGLMultipleRenderTargets: true; } diff --git a/types/three/src/renderers/WebGLRenderTarget.d.ts b/types/three/src/renderers/WebGLRenderTarget.d.ts index fb26aa6f4..a2265933d 100644 --- a/types/three/src/renderers/WebGLRenderTarget.d.ts +++ b/types/three/src/renderers/WebGLRenderTarget.d.ts @@ -5,7 +5,11 @@ import { RenderTarget, RenderTargetOptions } from '../core/RenderTarget.js'; export interface WebGLRenderTargetOptions extends RenderTargetOptions {} export class WebGLRenderTarget extends RenderTarget { - constructor(width?: number, height?: number, options?: WebGLRenderTargetOptions); + constructor( + width?: number | undefined, + height?: number | undefined, + options?: WebGLRenderTargetOptions | undefined, + ); readonly isWebGLRenderTarget: true; } diff --git a/types/three/src/renderers/WebGLRenderer.d.ts b/types/three/src/renderers/WebGLRenderer.d.ts index dd0925649..70af20764 100644 --- a/types/three/src/renderers/WebGLRenderer.d.ts +++ b/types/three/src/renderers/WebGLRenderer.d.ts @@ -137,7 +137,7 @@ export class WebGLRenderer implements Renderer { * The constructor also accepts no parameters at all. * In all cases, it will assume sane defaults when parameters are missing. */ - constructor(parameters?: WebGLRendererParameters); + constructor(parameters?: WebGLRendererParameters | undefined); /** * A Canvas where the renderer draws its output.