From 86f73778cbb7495544ffc1b56a59c33a6087ca37 Mon Sep 17 00:00:00 2001 From: Oksamies Date: Sun, 7 Jan 2024 22:20:44 +0200 Subject: [PATCH] Add DisbandTeamAPIView --- .../api/cyberstorm/tests/test_team.py | 73 +++++++++++++++++++ .../api/cyberstorm/views/__init__.py | 2 + .../thunderstore/api/cyberstorm/views/team.py | 37 ++++++++++ django/thunderstore/api/urls.py | 6 ++ 4 files changed, 118 insertions(+) diff --git a/django/thunderstore/api/cyberstorm/tests/test_team.py b/django/thunderstore/api/cyberstorm/tests/test_team.py index 66c0451cf..e3f8fef66 100644 --- a/django/thunderstore/api/cyberstorm/tests/test_team.py +++ b/django/thunderstore/api/cyberstorm/tests/test_team.py @@ -56,6 +56,79 @@ def test_team_api_view__for_inactive_team__returns_404( assert response.status_code == 404 +@pytest.mark.django_db +def test_team_disband__when_disbanding_team__succeeds( + api_client: APIClient, + user: UserType, + team: Team, +): + TeamMemberFactory(team=team, user=user, role="owner") + api_client.force_authenticate(user) + + response = api_client.post( + f"/api/cyberstorm/team/{team.name}/disband/", + json.dumps({"verification": team.name}), + content_type="application/json", + ) + + assert response.status_code == 200 + response_json = response.json() + assert response_json["name"] == team.name + + +@pytest.mark.django_db +def test_team_disband__when_disbanding_team__fails_because_verification_is_invalid( + api_client: APIClient, + user: UserType, + team: Team, +): + TeamMemberFactory(team=team, user=user, role="owner") + api_client.force_authenticate(user) + response = api_client.post( + f"/api/cyberstorm/team/{team.name}/disband/", + json.dumps({"verification": "Bad Verification"}), + content_type="application/json", + ) + + assert response.status_code == 400 + response_json = response.json() + assert "Invalid verification" in response_json["verification"] + + +@pytest.mark.django_db +def test_team_disband__when_disbanding_team__fails_because_team_doesnt_exist( + api_client: APIClient, + user: UserType, +): + api_client.force_authenticate(user) + response = api_client.post( + f"/api/cyberstorm/team/GhostTeam/disband/", + json.dumps({"verification": "GhostTeam"}), + content_type="application/json", + ) + + assert response.status_code == 404 + response_json = response.json() + assert response_json["detail"] == "Not found." + + +@pytest.mark.django_db +def test_team_disband__when_disbanding_team__fails_because_user_is_not_authenticated( + api_client: APIClient, + team: Team, +): + response = api_client.post( + f"/api/cyberstorm/team/{team.name}/disband/", + json.dumps({"verification": "Bad Verification"}), + content_type="application/json", + ) + + assert response.status_code == 401 + response_json = response.json() + assert response_json["detail"] == "Authentication credentials were not provided." + assert Team.objects.filter(name=team.name).count() == 1 + + @pytest.mark.django_db def test_team_edit__when_editing_donation_link__succeeds( api_client: APIClient, diff --git a/django/thunderstore/api/cyberstorm/views/__init__.py b/django/thunderstore/api/cyberstorm/views/__init__.py index 238d9f2c5..9d1df9ac8 100644 --- a/django/thunderstore/api/cyberstorm/views/__init__.py +++ b/django/thunderstore/api/cyberstorm/views/__init__.py @@ -12,6 +12,7 @@ from .package_rating import PackageRatingRateAPIView from .package_version_list import PackageVersionListAPIView from .team import ( + DisbandTeamAPIView, EditTeamAPIView, EditTeamMemberAPIView, RemoveTeamMemberAPIView, @@ -44,4 +45,5 @@ "RemoveTeamMemberAPIView", "EditTeamMemberAPIView", "EditTeamAPIView", + "DisbandTeamAPIView", ] diff --git a/django/thunderstore/api/cyberstorm/views/team.py b/django/thunderstore/api/cyberstorm/views/team.py index 4acc44510..8b81a45a0 100644 --- a/django/thunderstore/api/cyberstorm/views/team.py +++ b/django/thunderstore/api/cyberstorm/views/team.py @@ -22,6 +22,7 @@ from thunderstore.repository.forms import ( AddTeamMemberForm, CreateTeamForm, + DisbandTeamForm, DonationLinkTeamForm, EditTeamMemberForm, RemoveTeamMemberForm, @@ -121,6 +122,42 @@ def post(self, request: HttpRequest): raise ValidationError(form.errors) +class CyberstormDisbandTeamRequestSerialiazer(serializers.Serializer): + verification = serializers.CharField() + + +class CyberstormDisbandTeamResponseSerialiazer(serializers.Serializer): + name = serializers.CharField() + + +class DisbandTeamAPIView(APIView): + @conditional_swagger_auto_schema( + request_body=CyberstormDisbandTeamRequestSerialiazer, + responses={200: CyberstormDisbandTeamResponseSerialiazer}, + operation_id="cyberstorm.team.disband", + tags=["cyberstorm"], + ) + def post(self, request: HttpRequest, team_name: str): + serializer = CyberstormDisbandTeamRequestSerialiazer(data=request.data) + serializer.is_valid(raise_exception=True) + + team = get_object_or_404(Team, name__iexact=team_name) + + form = DisbandTeamForm( + user=request.user, + instance=team, + data=serializer.validated_data, + ) + + if form.is_valid(): + form.save() + return Response( + CyberstormDisbandTeamResponseSerialiazer({"name": team_name}).data + ) + else: + raise ValidationError(form.errors) + + class TeamMemberListAPIView(CyberstormAutoSchemaMixin, TeamRestrictedAPIView): permission_classes = [AllowAny] serializer_class = CyberstormTeamMemberSerializer diff --git a/django/thunderstore/api/urls.py b/django/thunderstore/api/urls.py index cb82a8252..4aa1a8e44 100644 --- a/django/thunderstore/api/urls.py +++ b/django/thunderstore/api/urls.py @@ -4,6 +4,7 @@ CommunityAPIView, CommunityFiltersAPIView, CommunityListAPIView, + DisbandTeamAPIView, EditTeamAPIView, EditTeamMemberAPIView, PackageDeprecateAPIView, @@ -121,6 +122,11 @@ TeamMemberListAPIView.as_view(), name="cyberstorm.team.member.list", ), + path( + "team//disband/", + DisbandTeamAPIView.as_view(), + name="cyberstorm.team.disband", + ), path( "team//member/add/", TeamMemberAddAPIView.as_view(),