Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect url redirect #840

Open
xiaoxiao921 opened this issue Apr 18, 2023 · 2 comments
Open

Incorrect url redirect #840

xiaoxiao921 opened this issue Apr 18, 2023 · 2 comments

Comments

@xiaoxiao921
Copy link

https://thunderstore.io/package/duckduckgreyduck/LazyBastardEngineer/

image

https://thunderstore.io/package/duckduckgreyduck/LazyBastardEngineer/plumicorn.itch.io/superbug
@MythicManiac
Copy link
Member

Seems like they haven't prefixed http(s):// to the link, which is why this is happening. Probably doesn't hurt for us to add the https:// prefix for links that don't have any defined.

MythicManiac added a commit that referenced this issue Apr 19, 2023
@MythicManiac
Enforce proper website_url formatting in manifests
c4f5138 
Make sure the package manifest.json website_url field is a properly
formatted URL and uses a known valid URL scheme. This should prevent
issues caused by incorrectly formatted links for downstream consumers,
although some older packages might of course contain incorrectly
formatted links.

Refs #840
@MythicManiac MythicManiac mentioned this issue Apr 19, 2023
Merged
@MythicManiac
Copy link
Member

Added validation for them in the above PR, but keeping this issue open until the link rendering is adjusted to auto-add a scheme prefix to the links that are currently missing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiaoxiao921 @MythicManiac