Enforce proper website_url formatting in manifests #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the package manifest.json website_url field is a properly formatted URL and uses a known valid URL scheme. This should prevent issues caused by incorrectly formatted links for downstream consumers, although some older packages might of course contain incorrectly formatted links. Refs #840
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 223 223
Lines 6779 6780 +1
Branches 667 667
=======================================
+ Hits 6214 6215 +1
Misses 475 475
Partials 90 90
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the package manifest.json website_url field is a properly formatted URL and uses a known valid URL scheme. This should prevent issues caused by incorrectly formatted links for downstream consumers, although some older packages might of course contain incorrectly formatted links.
Refs #840