Make community_list endpoint support required functionality #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #863 +/- ##
==========================================
+ Coverage 92.00% 92.04% +0.04%
==========================================
Files 252 252
Lines 7289 7307 +18
Branches 702 707 +5
==========================================
+ Hits 6706 6726 +20
+ Misses 486 485 -1
+ Partials 97 96 -1
☔ View full report in Codecov by Sentry. |
MythicManiac
approved these changes
Sep 18, 2023
anttimaki
force-pushed
the
cyberstorm-communitylist
branch
2 times, most recently
from
2a9641c
to
7e1f1ac
Compare
Moving from placeholder implementation to the real deal on the client side has revealed some shortcomings in the functionality and the returned data of this endpoint. - Add support for varying page size via page_size query param - Add support for filtering based on name and description fields via search query param - Add support for ordering by name and datetime_created fields - Add datetime_created and icon_url to serializer - Fields that can return null due to having Null=True in model definition are marked as optional in the serializer - Add naive implementations for Community's total_package_count and total_downloads_count properties - Add less naive implementation for icon_url property Refs TS-1815
anttimaki
force-pushed
the
cyberstorm-communitylist
branch
from
7e1f1ac
to
03b4275
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from placeholder implementation to the real deal on the client side has revealed some shortcomings in the functionality and the returned data of this endpoint.
Refs TS-1815