Add TeamCreateAPI view #937
Open
+104
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Oksamies
force-pushed
the
12-11-Add_TeamCreateAPI_view
branch
2 times, most recently
from
a4d49e7
to
f078a48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add-delete-user-endpoint #937 +/- ##
===========================================================
Coverage ? 93.07%
===========================================================
Files ? 299
Lines ? 8755
Branches ? 780
===========================================================
Hits ? 8149
Misses ? 500
Partials ? 106 ☔ View full report in Codecov by Sentry. |
MythicManiac
requested changes
Dec 12, 2023
|
|
||
| form = CreateTeamForm( | ||
| user=request.user, | ||
| data=request.data, |
There was a problem hiding this comment.
Neve ruse request.data directly when you use serializers to validate it; use serializer.validated_data
| name = serializers.CharField() | ||
|
|
||
|
|
||
| class TeamCreateAPIView(APIView): |
There was a problem hiding this comment.
Missing permission classes (user needs to be authenticated)
There was a problem hiding this comment.
All of the new views should now have IsAuthenticated
Oksamies
force-pushed
the
12-11-Add_TeamCreateAPI_view
branch
2 times, most recently
from
e8ddb16
to
c462637
Compare
Oksamies
force-pushed
the
12-11-Add_TeamCreateAPI_view
branch
3 times, most recently
from
f444a59
to
f5c8062
Compare
Oksamies
force-pushed
the
12-11-Add_TeamCreateAPI_view
branch
from
f5c8062
to
b8383d7
Compare
This was referenced Jun 24, 2024
Oksamies
force-pushed
the
add-delete-user-endpoint
branch
from
24bbf7f
to
9776b9d
Compare
Oksamies
force-pushed
the
12-11-Add_TeamCreateAPI_view
branch
from
b8383d7
to
dcd169a
Compare
Oksamies
force-pushed
the
add-delete-user-endpoint
branch
from
9776b9d
to
0645608
Compare
Oksamies
force-pushed
the
12-11-Add_TeamCreateAPI_view
branch
from
dcd169a
to
36350db
Compare
Oksamies
force-pushed
the
add-delete-user-endpoint
branch
from
0645608
to
01b117e
Compare
Oksamies
force-pushed
the
12-11-Add_TeamCreateAPI_view
branch
from
36350db
to
4e6236d
Compare
Oksamies
force-pushed
the
add-delete-user-endpoint
branch
from
01b117e
to
1d0e07f
Compare
Oksamies
force-pushed
the
12-11-Add_TeamCreateAPI_view
branch
2 times, most recently
from
5a9efff
to
ee40259
Compare
This was referenced Jul 18, 2024
Oksamies
force-pushed
the
add-delete-user-endpoint
branch
from
1d0e07f
to
018e671
Compare
Oksamies
force-pushed
the
12-11-Add_TeamCreateAPI_view
branch
from
ee40259
to
827af8b
Compare
Oksamies
force-pushed
the
add-delete-user-endpoint
branch
from
018e671
to
6f34766
Compare
Oksamies
force-pushed
the
12-11-Add_TeamCreateAPI_view
branch
from
827af8b
to
18c615f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.