Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems that the 4 bit field doesn't become effective. #19

Open
fangneverdown opened this issue Dec 12, 2022 · 1 comment
Open

It seems that the 4 bit field doesn't become effective. #19

fangneverdown opened this issue Dec 12, 2022 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@fangneverdown
Copy link

class LeafEntry {
public:
uint8_t f_version : 4;
Key key;
Value value;
uint8_t r_version : 4;

LeafEntry() {
f_version = 0;
r_version = 0;
value = kValueNull;
key = 0;
}
} attribute((packed));

The size of LeafEntry is still 18 bytes, not 17. Is there any other solution to save 1 byte?

@Transpeptidase
Copy link
Collaborator

Hi, thank you for pointing out this bug. To save the 1 byte, we should operate the LeafEntry via bit-shift operations

@Transpeptidase Transpeptidase added the help wanted Extra attention is needed label Dec 13, 2022
@fangneverdown fangneverdown reopened this Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants