Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is the difference between creating data with or without virtual point? #25

Open
zw615 opened this issue Oct 1, 2022 · 1 comment

Comments

@zw615
Copy link

zw615 commented Oct 1, 2022

Hi! Thank you for your great work!

I am following the instructions in getting_started. However, I fail to understand the difference between creating data with virtual points (MVP) and creating data without virtual points (CenterPoint Baseline). Based on the instructions, the command for MVP is

# nuScenes
python tools/create_data.py nuscenes_data_prep --root_path=NUSCENES_TRAINVAL_DATASET_ROOT --version="v1.0-trainval" --nsweeps=10 --virtual True 

And the command for CenterPoint is

# nuScenes
python tools/create_data.py nuscenes_data_prep --root_path=NUSCENES_TRAINVAL_DATASET_ROOT --version="v1.0-trainval" --nsweeps=10 --virtual False 

It seems to me that the only difference is --virtual, which is only used in creating gt sampling here. But according to the instructions, the improvements of gt sampling on nuscenes is marginal and thus can be simply discarded. If that is the case, it seems to me there is no real difference between creating data with or without virtual points.

Am I missing something here? Thanks!

@tianweiy
Copy link
Owner

tianweiy commented Oct 1, 2022

you are right that the only difference is whether or not we create gt dataset with virtual points.

But according to the instructions, the improvements of gt sampling on nuscenes is marginal and thus can be simply discarded

In general, this is right. But if we want to compete with other approaches, we need this extra 0,5 nds :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants