Skip to content

Commit 9f017f7

Browse files
author
dgrtwo
committed
Modifications in response to CRAN comments; this is 0.3.5 on CRAN. Removed lme4.0 tidiers, and from SUGGESTS. Removed 'require("maptools")' line.
1 parent f5065a3 commit 9f017f7

File tree

7 files changed

+8
-75
lines changed

7 files changed

+8
-75
lines changed

DESCRIPTION

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,9 @@ Suggests:
3636
multcomp,
3737
testthat,
3838
lme4,
39-
lme4.0,
4039
zoo,
4140
ggplot2
4241
URL: http://github.com/dgrtwo/broom
4342
BugReports: http://github.com/dgrtwo/broom/issues
4443
VignetteBuilder: knitr
4544
License: MIT + file LICENSE
46-
Additional_repositories: http://lme4.r-forge.r-project.org/repos

NAMESPACE

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ S3method(augment,default)
77
S3method(augment,felm)
88
S3method(augment,kmeans)
99
S3method(augment,lm)
10-
S3method(augment,mer)
1110
S3method(augment,merMod)
1211
S3method(augment,nls)
1312
S3method(augment,rowwise_df)
@@ -29,7 +28,6 @@ S3method(glance,glmnet)
2928
S3method(glance,htest)
3029
S3method(glance,kmeans)
3130
S3method(glance,lm)
32-
S3method(glance,mer)
3331
S3method(glance,merMod)
3432
S3method(glance,nls)
3533
S3method(glance,pyears)
@@ -72,7 +70,6 @@ S3method(tidy,kmeans)
7270
S3method(tidy,lm)
7371
S3method(tidy,manova)
7472
S3method(tidy,map)
75-
S3method(tidy,mer)
7673
S3method(tidy,merMod)
7774
S3method(tidy,nls)
7875
S3method(tidy,pairwise.htest)

NEWS.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
broom 0.3.5
22
-----------
33

4-
* Added tidiers for `mer` objects from lme4.0 and versions of lme4 prior to 1.1-7.
54
* Fixed small bug in `felm` where the `.fitted` and `.resid` columns were matrices rather than vectors.
65
* Added tidiers for `rlm` (robust linear model) and `gam` (generalized additive model) objects, including adjustments to "lm" tidiers in order to handle them. See `?rlm_tidiers` and `?gam_tidiers` for more.
76
* Removed rownames from `tidy.cv.glmnet` output

R/lme4_tidiers.R

Lines changed: 1 addition & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
#' Tidying methods for mixed effects models
22
#'
33
#' These methods tidy the coefficients of mixed effects models, particularly
4-
#' responses of the \code{merMod} and \code{mer} (from lme4.0 and versions prior
5-
#' to 1.1-7)
4+
#' responses of the \code{merMod} class
65
#'
76
#' @param x An object of class \code{merMod}, such as those from \code{lmer},
87
#' \code{glmer}, or \code{nlmer}
@@ -162,47 +161,3 @@ glance.merMod <- function(x, ...) {
162161
ret <- unrowname(data.frame(sigma = lme4::sigma(x)))
163162
finish_glance(ret, x)
164163
}
165-
166-
167-
## "mer" methods
168-
169-
170-
#' @rdname lme4_tidiers
171-
#'
172-
#' @export
173-
tidy.mer <- function(x, effects = "random", ...) {
174-
# pass directly on to lme4 method
175-
effects <- match.arg(effects, c("random", "fixed"))
176-
if (effects == "fixed") {
177-
# return tidied fixed effects rather than random
178-
ret <- coef(lme4.0::summary(x))
179-
180-
# p-values may or may not be included
181-
nn <- c("estimate", "std.error", "statistic", "p.value")[1:ncol(ret)]
182-
return(fix_data_frame(ret, newnames = nn, newcol = "term"))
183-
}
184-
185-
# for random effects, can pass on to lme4 method
186-
tidy.merMod(x, effects = "random", ...)
187-
}
188-
189-
190-
#' @rdname lme4_tidiers
191-
#'
192-
#' @export
193-
augment.mer <- function(x, data = model.frame(x), newdata, ...) {
194-
if (missing(newdata)) {
195-
newdata <- NULL
196-
}
197-
ret <- augment_columns(x, data, newdata, se.fit = NULL)
198-
ret
199-
}
200-
201-
202-
#' @rdname lme4_tidiers
203-
#'
204-
#' @export
205-
glance.mer <- function(x, ...) {
206-
ret <- unrowname(data.frame(sigma = lme4.0::sigma(x)))
207-
finish_glance(ret, x)
208-
}

R/sp_tidiers.R

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ tidy.SpatialPolygonsDataFrame <- function(x, region = NULL, ...) {
3434
message("Regions defined for each Polygons")
3535
} else {
3636
cp <- sp::polygons(x)
37-
require("maptools")
3837

3938
# Union together all polygons that make up a region
4039
unioned <- maptools::unionSpatialPolygons(cp, attr[, region])

cran-comments.md

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,15 @@
1+
## Resubmission
2+
This is a resubmission. In this version I have
3+
4+
* Removed 'require("maptools")' call that led to a NOTE on R-devel
5+
16
## Test environments
27
* local OS X install, R 3.1.2
38
* ubuntu 12.04 (on travis-ci), R 3.1.2
49
* win-builder (devel and release)
510

611
## R CMD check results
7-
There were no ERRORs or WARNINGs.
8-
9-
There was 1 NOTE:
10-
11-
* checking package dependencies ... NOTE
12-
Package suggested but not available for checking: ‘lme4.0’
13-
14-
This is available from R-forge, and an appropriate repository has been
15-
included in the additional repositories field in DESCRIPTION.
16-
17-
R6 is a build-time dependency.
12+
There were no ERRORs, WARNINGs or NOTEs.
1813

1914
## Reverse dependencies
2015
Broom has no reverse dependencies.

man/lme4_tidiers.Rd

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
% Generated by roxygen2 (4.1.0): do not edit by hand
22
% Please edit documentation in R/lme4_tidiers.R
33
\name{lme4_tidiers}
4-
\alias{augment.mer}
54
\alias{augment.merMod}
6-
\alias{glance.mer}
75
\alias{glance.merMod}
86
\alias{lme4_tidiers}
9-
\alias{tidy.mer}
107
\alias{tidy.merMod}
118
\title{Tidying methods for mixed effects models}
129
\usage{
@@ -15,12 +12,6 @@
1512
\method{augment}{merMod}(x, data = model.frame(x), newdata, ...)
1613

1714
\method{glance}{merMod}(x, ...)
18-
19-
\method{tidy}{mer}(x, effects = "random", ...)
20-
21-
\method{augment}{mer}(x, data = model.frame(x), newdata, ...)
22-
23-
\method{glance}{mer}(x, ...)
2415
}
2516
\arguments{
2617
\item{x}{An object of class \code{merMod}, such as those from \code{lmer},
@@ -75,8 +66,7 @@ are values from the response object within the model (of type
7566
}
7667
\description{
7768
These methods tidy the coefficients of mixed effects models, particularly
78-
responses of the \code{merMod} and \code{mer} (from lme4.0 and versions prior
79-
to 1.1-7)
69+
responses of the \code{merMod} class
8070
}
8171
\details{
8272
When the modeling was performed with \code{na.action = "na.omit"}

0 commit comments

Comments
 (0)