Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anchoring redesign. #47

Open
sa-lee opened this issue Jul 29, 2018 · 3 comments
Open

anchoring redesign. #47

sa-lee opened this issue Jul 29, 2018 · 3 comments
Labels

Comments

@sa-lee
Copy link
Collaborator

sa-lee commented Jul 29, 2018

There was some general confusion about this during the talk/workshop at Bioc2018. People felt it was not intuitive that the anchoring is dropped after a mutate call and that anchoring decorates a GRanges object. There was a suggestion of making anchoring act like dplyr's scoped variants so something like:

gr %>% mutate_at_anchor(..., anchor = "start")

could be a possibility. I think I need to think about this a bit more though.

@lawremi
Copy link
Collaborator

lawremi commented Jul 29, 2018

Since there are only three possible anchors (five for stranded), we could just enumerate: mutate_with_fixed_start(), mutate_with_fixed_end(). Another idea is kinda like ascending() in dplyr. Just cast the width assignment:

mutate(anchor_at_start(width = width * 2), score = score / mean(score)

That's attractive because it doesn't cause explosion in the verb names, and it localizes the anchor aspect to the width manipulation, where it actually matters. There's no decoration of the GRanges although there is a virtual decoration of the expression, but that's not a big deal.

@sa-lee
Copy link
Collaborator Author

sa-lee commented Jul 30, 2018

I like that, I think the code would look more like dplyr if you set width outside the call to anchor_* and there's no confusion for how update columns using mutate()

mutate(width = anchor_on_start(width * 2), ...)

@lawremi
Copy link
Collaborator

lawremi commented Jul 30, 2018

Yea, good point. I think the preposition should be to, like anchor_to_start(). At least that's how we would say it in English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants