fix: list_transpose() takes into account all elements for the template
#1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Aug 15, 2024
| Code | ||
| list_transpose(list(x = list(a = 1, b = 2), y = list(3, 4))) | ||
| Condition | ||
| Error in `fn()`: |
There was a problem hiding this comment.
Do you think it's worth making this error a bit more clear? At a minimum, it seems like it'd be worth wrapping it to give some context and a more useful call.
|
Good catch, done. No idea how I missed committing the snapshots... |
|
Do you still think it's worth having a |
|
I think so? It's hard to tell that this message arises because by generating a default value for an argument. |
hadley
reviewed
Aug 15, 2024
R/list-transpose.R
Outdated
| vec_set_union, | ||
| error_call = caller_env() | ||
| indexes <- map(x, vec_index) | ||
| try_fetch( |
There was a problem hiding this comment.
withCallingHandlers should be adequate here.
R/list-transpose.R
Outdated
| vctrs_error_ptype2 = function(e) { | ||
| cli::cli_abort( | ||
| "Can't combine named and unnamed vectors.", | ||
| arg = template |
|
Closes #1128. |
krlmlr
force-pushed
the
b-1128-list-transpose
branch
from
f6d6ec7
to
d7e21af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an error for the case when mixing named and unnamed elements, it was a silent error before.
Closes #1128.