Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package to autoware_ndt_omp #67

Closed
esteve opened this issue Sep 17, 2024 · 4 comments
Closed

Rename package to autoware_ndt_omp #67

esteve opened this issue Sep 17, 2024 · 4 comments

Comments

@esteve
Copy link

esteve commented Sep 17, 2024

There is an ongoing effort to prefix all packages with autoware_ to prevent clashes with existing packages and to signal that these are packages that are part of the Autoware project.

In fact, because this package is still named ndt_omp and the original upstream package is already in the ROS index, our buildfarm is can't any package that depends on ndt_omp properly (see autowarefoundation/autoware#4569). For now, I'm ignoring ndt_omp and ndt_scan_matcher in the buildfarm, but it'd be great if at least ndt_omp is renamed soon.

@esteve
Copy link
Author

esteve commented Oct 29, 2024

@SakodaShintaro @YamatoAndo @mitsudome-r @xmfcx I remember that it was planned to integrate ndt_omp inside autoware_ndt_scan_matcher, but this repository is still separate. Unfortunately because the package in this repository has the same name as in the ROS index, it's still breaking the builds in autowarefoundation/autoware-deb-packages#98

For now I'll ignore autoware_ndt_scan_matcher in the builds, but we need to find a way to avoid duplicate package names:

  • We rename ndt_omp to something else (e.g. autoware_ndt_omp, tier4_ndt_omp, etc.)
  • We integrate the code from ndt_omp into autoware_ndt_scan_matcher and remove the dependency for ndt_omp

@SakodaShintaro
Copy link

@esteve
Copy link
Author

esteve commented Oct 29, 2024

@SakodaShintaro oh, sorry I missed that comment, I'll reply there. Thanks for the link

@YamatoAndo
Copy link

This issue has been resolved by moving ndt_omp into autoware_ndt_scan_matcher, so I will close this issue.
autowarefoundation/autoware.universe#8912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants