Network Watcher should be parameterized on from client code

[pulingupta]

https://github.com/tietoevry-infra-as-code/terraform-azurerm-caf-vnet-hub/blob/master/main.tf#L59, can this be a parameter with some default value

[kumarvit]

Hi,

Azure Network Watcher enabled by default for subscriptions that contain virtual networks. This is a region-level service which can be used to troubleshoot network connectivity between Azure resources. If you do not want the “NetworkWatcherRG” resource group the trick is to create the instance of Network Watcher manually using Azure CLI or PowerShell.

However, to keep the module generic to everyone, I am keeping this to the default name “NetworkWatcherRG”. This way, we can avoid creating the network watcher resource group and corresponding watcher resources in that region if they already exist. We can parameterize this as well. I will correct this in the next release. Thanks for pointing out!