Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch zoom on iPad causes final image position to jump #17

Open
n1ru4l opened this issue Jun 8, 2020 · 6 comments
Open

Pinch zoom on iPad causes final image position to jump #17

n1ru4l opened this issue Jun 8, 2020 · 6 comments

Comments

@n1ru4l
Copy link

n1ru4l commented Jun 8, 2020

I just discovered this library and used the demo and noticed that the content sometimes is moved after the pinch zoom gesture has ended.

I created a video recording of this:

https://drive.google.com/file/d/1Y_S7kQX2d7BnPr5xaLNIXXdhybB8qMEu/view?usp=sharing

@n1ru4l
Copy link
Author

n1ru4l commented Jun 8, 2020

This is the same behavior I reported over here: pmndrs/use-gesture#180 (comment)

@tim-soft
Copy link
Owner

tim-soft commented Jun 8, 2020

@n1ru4l thanks for the feedback! I don't have an iPad on hand, can you repro on a non-iOS device? Which browser were you using? I plan on upgrading to react-use-gesture 8.0.0 when it goes stable and the next react-spring RC after a few issues are ironed out which may solve the problem

@n1ru4l
Copy link
Author

n1ru4l commented Jun 8, 2020

@tim-soft I was using Safari on iOS 13.4, unfortunately I don’t own an android device. On Chrome on Desktop everything seems okay.

Edit: I double-checked the trackpad on a MacBook and there the pinch-zooming works fine on Chrome. On Safari the whole page is zoomed instead of the image.

@tim-soft
Copy link
Owner

tim-soft commented Jun 8, 2020

Could you try Chrome on your iPad? Sounds like I need to get my hands on some apple devices for more testing

@n1ru4l
Copy link
Author

n1ru4l commented Jun 8, 2020

Chrome on iPad is only a wrapper around the Safari engine. Despite that fact I checked and the behaviour is the same 😔.

Yeah, I just bought that one myself as I want to improve my apps performance. It also seems like the react-use-gesture maintainer does not have an iPad too, which sucks. Maybe if we get together enough people we could sponsor it somehow.

@tim-soft
Copy link
Owner

tim-soft commented Jun 8, 2020

no worries, I just need to carve out some time to take a closer look. I'll update this issue when I get it fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants