From 2c2f8fd3fe4163bc41d0b9f9486c5ed49f77bd52 Mon Sep 17 00:00:00 2001 From: Ubuntu Date: Thu, 20 Feb 2020 09:20:19 +0100 Subject: [PATCH] Http Request Duration Histogram should be in seconds unit --- cmd/prometheus-postgresql-adapter/main.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/prometheus-postgresql-adapter/main.go b/cmd/prometheus-postgresql-adapter/main.go index f386fad..65f4366 100644 --- a/cmd/prometheus-postgresql-adapter/main.go +++ b/cmd/prometheus-postgresql-adapter/main.go @@ -92,8 +92,8 @@ var ( ) httpRequestDuration = prometheus.NewHistogramVec( prometheus.HistogramOpts{ - Name: "http_request_duration_ms", - Help: "Duration of HTTP request in milliseconds", + Name: "http_request_duration_seconds", + Help: "Duration of HTTP request in seconds", Buckets: prometheus.DefBuckets, }, []string{"path"}, @@ -396,8 +396,8 @@ func timeHandler(path string, handler http.Handler) http.Handler { f := func(w http.ResponseWriter, r *http.Request) { start := time.Now() handler.ServeHTTP(w, r) - elapsedMs := time.Since(start).Nanoseconds() / int64(time.Millisecond) - httpRequestDuration.WithLabelValues(path).Observe(float64(elapsedMs)) + elapsedSec := time.Since(start).Nanoseconds() / int64(time.Second) + httpRequestDuration.WithLabelValues(path).Observe(float64(elapsedSec)) } return http.HandlerFunc(f) }