Allow relative paths (and/or support ~)

[weotch]

I was hoping to be able to use ~ in my deployTo, like "~/myapp/staging". However, the tilde doesn't work when it's used with quotes like:

Error: Command failed: /bin/sh -c ssh xxxxx@xxx.xxx.xxx.xxx "if ( ! [ -h \"~/myapp/staging/releases/20151129224812/storage/framework/sessions\" ] ); then rm -rf \"~/myapp/staging/releases/20151129224812/storage/framework/sessions\" 2> /dev/null; ln -s \"~/myapp/staging/shared/storage/framework/sessions\" \"~/myapp/staging/releases/20151129224812/storage/framework/sessions\"; fi"
ln: failed to create symbolic link ‘~/myapp/staging/releases/20151129224812/storage/framework/sessions’: No such file or directory

Are the quotes surrounding the paths even necessary? FWIW, I tried using $HOME instead of ~ but it breaks some of the shipit-deploy stuff.

[timkelty]

I'd have to do some tests, but I'm pretty sure the quotes are necessary in many cases (a folder with a space).

Seems like we should be able to get $HOME working though...

Have you tried defining deployTo as a relative path (myapp/staging)? That should have the same result as using '~', since everything will just be relative to the SSH'd user's $HOME

[weotch]

I'd have to do some tests, but I'm pretty sure the quotes are necessary in many cases (a folder with a space).

Yeah, I expect you're right about that.

Have you tried defining deployTo as a relative path (myapp/staging)?

Just did, that works! Thanks for the suggestion.

[weotch]

Just realized today that this solution actually didn't work. Errors weren't being thrown but the symlinks were bad, they pointed to directories that didn't exist.

I tried to manually expand my tildes like this:

shipit.blTask('tilde', function() {
  if (shipit.config.deployTo.indexOf('~/') < 0) {
    return;
  }
  return shipit.remote('echo ~/').then(function(servers) {
    var path;
    path = servers[0].stdout.trim();
    shipit.config.deployTo = shipit.config.deployTo.replace('~/', path);
  });
});

The shared:link:dirs task does use the modified shipit.config.deployTo but the shared:create-dirs task doesn't, using the original, tilde-ed deployTo.

I can just use absolute paths, but I wanted to update the ticket for others sake.

[timkelty]

Thanks, i'll keep this open and think about a better solution.

[albertogasparin]

+1 on this as it would be helpful

[gagarine]

This is quiet important when you don't know your home full path of in your target VM. Your ~ is in somethings like /home/a5af69633fa20da5745ffbc/ and each VM has a new random path.

[timkelty]

@gagarine haven't had time yet, but am certainly open to a PR.