Is Database Upgrade too forceful?

[dalers]

The only available user action after logging in as an admin user and facing the Database Upgrade script is [Continue with Updates].

Must it be so forceful? Should "Ignore" or "Logout" be provided to continue operation without changes until backups have been made and/or critical work has been completed (or just to ignore a point release until the next major release)?

Also, I noticed using Chrome that if I close the Chrome tab and then access weberp using a new tab, I am immediately presented with the Database Upgrade script, I don't even have to login. This is different with MS Edge. Using Edge, I always have to login (and then get presented with Z_UpgradeDatabase. Should this be reported as an issue?

[pakricard]

I think we could have a “logout”, but not an “ignore”, as the code and DB must be in sync. If we update the code (thus the user see that upgrade DB page), it is because something in the code changed that needs some changes in the DB.

Probably the webERP admin should not upgrade the code in the middle of any critical work, but this applies to any software upgrade, I guess.

But having a “logout” doesn't help much, as you can't move forward. I think it's OK as is.

R

[dalers]

Doh! (Homer Simpson rederence). Of course you are right, once code has been updated the db update MUST be performed before the system can be used. Now I recall a discussion in which we determined that regular users need to be forcibly logged out to prevent them from running new code on an old schema.

[dalers]

Or maybe it's not forceful enough? Perhaps there should be three buttons:

1. send a warning to all users that the system is going down soon
2. force disconnection of all users (their next click will fail)
3. run update script

[dalers]

Possible implementation:

1. send warning to all users that the system is going down soon - the button sets a “system going down” variable (in the config table?) that could be checked in the header (used by all pages), and if true @ErrMsg() called to warn the "system is going down soon". The company (and their sysop) can adopt a protocol requiring e.g. a 30 minute preliminary warning and a 10 minute final warning.

2. "force logout" needs to prevent any script from writing to the datase but allows in-flight writes to complete. This could be done by setting a global timeout value to zero causing normal users to be logged out before they could perform a write to the database.

[dalers]

Mockup:

The "Force Logout" button doesn't need to check for active users since it's impossible to determine this for certain (e.g. the "LoggedInUsers.php" script can report a false positive through no fault of its own as was discussed around the time it was created) and only changes the (new) global timeout to either zero or its default value.

[dalers]

Closed as no longer relevant. Issue #821 created to sdd buttons to update script.