Add datetime string to span element as title #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution ! |
|
It seems we need to update some unit tests also |
|
And tz is tricky as browsers might convert it to local timezone. Good to add. |
|
Sorry, I made a silly mistake. Now the tests run through.
Good to add the timezone to the string? Would you prefer this as a separate date format or part of |
|
Ping @timvink Is this good as is or should we add the timezone as well (see questions above)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple solution to get the datetime on hover over the
<span>element.Alternative/additional solution
GitHub and GitLab include the timezone as well:
GitHub
GitLab
We could also consider having the title include the timezone (although I realized that depends on the presence of the
timezonesetting as well, otherwise it would be UTC) [side question here: would it be better to default to the system timezone here?]Fixes #131