Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] text with the generated colors isn't very readable #81

Closed
salahoued opened this issue Nov 2, 2024 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@salahoued
Copy link

Describe the bug

I use tinty to generate custom schemes from the wallpaper, but sometimes the generated colors (base08-base0F) in a dark
color scheme aren't very readable when using base00 as background color

Expected behavior

When generating a dark color scheme the color from base08 to base0F should be showing and readable with the backgroud base00, just like the foreground color base07. and those colors 'should' 'lighter'.

Screenshots

konsole
alacritty

Terminal:
Konsole (most of the time) and alacritty

Minimal configuration file

# Global settings
shell = "bash -c '{}'"
# default-scheme = "base16-mocha"
#hooks = [ "command1", "command2" ]

# Item configurations
[[items]]
name = "tinted-shell"
path = "~/.local/share/tinted-theming/tinty/repos/tinted-shell"
themes-dir = "scripts"
hook = "source %f"
supported-systems = ["base16"]

[[items]]
name = "base16-rofi"
path = "~/.local/share/tinted-theming/tinty/repos/base16-rofi"
themes-dir = "colors"
hook = "cp -r %f ~/.config/rofi/colors.rasi"

[[items]]
name = "base16-fzf"
path = "~/.local/share/tinted-theming/tinty/repos/base16-fzf"
themes-dir = "bash"
hook = "cp -r %f ~/.fzfcolors.sh && source ~/.fzfcolors.sh"
supported-systems = ["base16"]
@salahoued salahoued added the bug Something isn't working label Nov 2, 2024
@JamyGolden
Copy link
Member

Thanks for creating the issue. Yeah totally, 08-0F should be readable on base00. It’s finding the closest colours to red, orange, yellow, etc. but if it can’t it defaults to the closest value, however I can make sure that if it finds something, the brightness is above some threshold otherwise it forces it. I’ll look more closely into this in the next week or so.

@JamyGolden
Copy link
Member

JamyGolden commented Dec 20, 2024

@salahoued I've updated the color scheme generator. It now checks to see if the brighter colors aren't bright enough and if so, it bumps the luminosity up a bit. Let me know if you get better results with this. It is updated in Tinty 0.24.0

@salahoued
Copy link
Author

Thank you, much appreciated
It is much better now, before its very hard to use helix with the generated scheme
2024-12-20-172642_hyprshot

@JamyGolden
Copy link
Member

That's great to hear! 😄 Thanks again for creating the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants