Problems with File Caching

[dbautistadecabo]

I have a title/description problem in MediaWiki 1.24.1 with the last WikiSEO clone and File Caching.

I have pages with the {{#seo}} tag and pages without it. When I run maintenance/rebuildFileCache.php many of the html-cached pages (I think all the ones without the seo tag) get the same title from a page called 'Problemas de calidad de voz' with this seo tag:

{{#seo:
|title=Problemas de calidad de voz
|titlemode=append
|keywords=problemas voip,baja calidad de voip,mala calidad sonido,voip,voz sobre ip,calidad de voz,imagen profesional,teletrabajo,dual sim
|description=Principales problemas con la calidad de voz del voip (voz sobre ip)
}}

Then, for instance, the page "Página principal" (which has not the seo tag) gets this tags:

<title>Página principal - Problemas de calidad de voz</title>
<meta name="keywords" content="problemas voip,baja calidad de voip,mala calidad sonido,voip,voz sobre ip,calidad de voz,imagen profesional,teletrabajo,dual sim" />
<meta name="description" content="Principales problemas con la calidad de voz del voip (voz sobre ip)" />
<meta name="twitter:description" content="Principales problemas con la calidad de voz del voip (voz sobre ip)" />

If I remove that SEO tag from the 'Problemas de calidad de voz' page, then tags from another page with the SEO tag appear on "Página principal".

The strange thing is that it only happens with maintenance/rebuildFileCache.php and not with the live page (without caching).

What am I doing wrong? Thanks in advance.

[dbautistadecabo]

Some debugging:

On the first page (it has the SEO tag) the methods are called in this order: init, parserFunction, processParams, renderParamsAsHtmlComments, loadParamsFromWikitext, processParams, modifyHTML.
On the second page (without the SEO tag) the methods are called: loadParamsFromWikitext, modifyHTML.
On a page > 2nd with the SEO tag: parserFunction, processParams, renderParamsAsHtmlComments, loadParamsFromWikitext, processParams, modifyHTML.
On a page > 2nd without the SEO tag: loadParamsFromWikitext, modifyHTML.

It seems that the SEO info is stored from page to page, and not modified if the page has not the SEO tag, and uncorrectly used in this pages... Any solution for this?

[andru]

Confusing. Params are stored in the page text, and pulled out by loadParamsFromWikitext, which should only be operating on the active page (and therefore shouldn't get anything from a page which doesn't use wikiseo) so the cache must be doing something I haven't anticipated. I don't have any time to work on this extension right now but I'll look into it when I can. If you find a solution in the meantime be sure to let me know.

[andru]

Ah, I just re-read your initial issue and I think I know the reason for the bug. This extension assigns the params from the page to the WikiSEO singleton which is usually fine since one http request = one mediawiki render stack. When running a maintenance script, multiple pages get rendered from the same environment, so those param values on the WikiSEO singleton are getting carried overt o subsequent renders.

Solution: reset the singleton on each render somehow. Possibly with the ParserFirstCallInit hook, I'm not sure exactly what hooks will be getting called during that maintenance script.

If you want to take a stab at a fix I'll gladly accept a pull request, otherwise I'll take a look when I've next got a project which depends on this extension.

[dbautistadecabo]

Hi!

It seems that 'init' hook is only called one time when the rebuildFileCache.php script is executed. So in theory the fact that the class is singleton should not affect.

Thus, I've applied a dirty hack which seems to make it work. I clean the class attributes at the end of modifyHTML method (I'm assuming it's the last one to be called and it's called only once) in order not to affect the next pages processed:

public static function modifyHTML ( $out ) {
  ...
  // clean for the next iteration (scripts)
  self::$title = '';
  self::$title_mode = 'replace';
  self::$title_separator = ' - ';
  self::$meta = array();
  self::$property = array();
  // ok
  return true;
}

It should not affect the normal operation (one page served).

[andru]

Great. If you wanted to send that over as a pull request I'll merge it in. If not I'll get to it when I can.