-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test friend account and Unicode in Submission.student_uniqname #13
Comments
After doing some testing, I determined that the database and process can handle most Unicode characters, but the database appears to struggle with the four-byte UTF8 characters. Colleagues have been working on handling this in other applications (see tl-its-umich-edu/my-learning-analytics#992), and It seems like, if this doesn't cause other issues, it would be worth resolving now. |
Regarding friend accounts and special characters, there are almost no cases of non-ASCII characters in Canvas unique names (or |
The |
PRs #38 and #39 should handle the issues regarding friend accounts and Unicode that I have identified in our application. Going forward, we'll need to investigate and monitor how the application and M-Pathways perform with respect to friend accounts. I am going to leave this issue open as a reminder to keep an eye on this. If all concerns are dissipated in the future, we can resolve. |
Raised by @pushyamig while reviewing PR #12
In the previous iteration of the project, we have had issues sending scores with emails and Unicode in the string for the students' uniqname. While this problem may be obviated by the new batch M-Pathways endpoint -- since the strings are passed as JSON, rather than in the URL -- we still need to test to ensure this works properly given these cases. If there are issues, tests and fixtures should be created to ensure the code properly handles these strings.
The text was updated successfully, but these errors were encountered: