Validate student uniqnames during cohort creation

[mfldavidson]

If a cohort is created and contains a bad student uniqname, the way this displays to the end user is that where that value would appear in their My Students view is replaced by the value "NotHappen". This maps to the -2 Not Happened Yet value in CNLYR002 DM_CHRT

Better way would be to validate the uniqnames as the cohort is created and notify user of the uniqname that is invalid and not let them create the cohort until corrected. I'm backlogging this since we're looking at revamping the cohort creation process and that would render this issue moot, but I wanted to add the issue just in case/so we remember that this has happened.

[jonespm]

It’ll be really inefficient to validate against the UM-API, especially with large cohorts like LSA. Maybe we can just validate against the DM_STDNT. I also think we'd have to do this in batch rather than a request for each row in the cohort, so maybe warn after ward?

I think this is kind of might be a feature as part of a better/different cohort loading process.

[mfldavidson]

Yes that would be fine. No need to figure it out as this will likely end up as one we won't do.

[mfldavidson]

While investigating something else I noticed how we can at least get rid of the "Not Happened Yet" "person" on the advisor's list view. Right now, I don't want to do this, because I don't have another easy way to determining if uniqnames in cohort uploads are bad, but I'm logging here for the future. In some views in https://github.com/tl-its-umich-edu/student_explorer/blob/develop/seumich/views.py the queryset filters by id_gte=0 to eliminate ids less than 0 which are all things like NotHappen and BadValue. This can be seen in AdvisorListView (27-28) and CohortListView (34-35). However, the view that is showing the Not Happened Yet person is AdvisorView which doesn't have this filter to rule out students with id less than 0. We could add it.