Way faster without spinner (#490)

Author: BuonOmo

lib/tldr.js

@@ -3,7 +3,6 @@
 const sample = require('lodash/sample');
 const fs = require('fs-extra');
 const ms = require('ms');
-const ora = require('ora');
 const { EmptyCacheError, MissingPageError, MissingRenderPathError } = require('./errors');
 const Cache = require('./cache');
 const search = require('./search');
@@ -140,19 +139,15 @@ class Tldr {
    * @returns {Promise<any>} The index.
    */
   updateCache() {
-    return spinningPromise('Updating...', () => {
-      return this.cache.update();
-    });
+    return this.cache.update();
   }
 
   /**
    * Update the index.
    * @returns {Promise<any>} The index.
    */
   updateIndex() {
-    return spinningPromise('Creating index...', () => {
-      return search.createIndex();
-    });
+    return search.createIndex();
   }
 
   /**
@@ -204,13 +199,9 @@ class Tldr {
           if (this.config.skipUpdateWhenPageNotFound === true) {
             return '';
           }
-          return spinningPromise('Page not found. Updating cache...', () => {
-            return this.cache.update();
-          })
+          return this.cache.update()
             .then(() => {
-              return spinningPromise('Creating index...', () => {
-                return search.createIndex();
-              });
+              return search.createIndex();
             })
             .then(() => {
               // And then, try to check in cache again
@@ -263,24 +254,4 @@ class Tldr {
   }
 }
 
-/**
- * Display a spinner while a task is running.
- * @param {string} text The text of the spinner.
- * @param {Function} factory A task to be run.
- * @returns {Promise<unknown>} A promise with the result of the task.
- */
-function spinningPromise(text, factory) {
-  const spinner = ora();
-  spinner.start(text);
-  return factory()
-    .then((val) => {
-      spinner.succeed();
-      return val;
-    })
-    .catch((err) => {
-      spinner.fail();
-      throw err;
-    });
-}
-
 module.exports = Tldr;