Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#passages element #11

Open
tmedwards opened this issue Apr 18, 2020 · 2 comments
Open

#passages element #11

tmedwards opened this issue Apr 18, 2020 · 2 comments
Assignees
@tmedwards
Labels
investigate Information gathering is needed

Comments

@tmedwards
Copy link
Owner

Consider removing the #passages element. It's a holdover from SugarCube's roots and unnecessary for normal functioning.

The only concern would be if it's required for some user layouts.
@tmedwards tmedwards transferred this issue from another repository Aug 2, 2020
@tmedwards tmedwards self-assigned this Aug 2, 2020
@tmedwards tmedwards added the investigate Information gathering is needed label Aug 2, 2020
@Uzume
Copy link

Uzume commented Oct 20, 2020 •
edited
Loading

Currently it is required in the StoryInterface special passage (as mentioned in #24 ). I am not sure how one would specify the UI without it.

@tmedwards
Copy link
Owner Author

Currently true, but also irrelevant. The #passages element's only true function within the core markup is as the container for .passage elements, a function that could just as easily be served by the #story element.

As I noted, aside from possibly being explicitly referenced within user CSS, which could affect those layouts, it's entirely vestigial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmedwards tmedwards

Labels
investigate Information gathering is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmedwards @Uzume