Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up modelToXML? #29

Open
sorawee opened this issue Mar 12, 2020 · 2 comments
Open

Clean up modelToXML? #29

sorawee opened this issue Mar 12, 2020 · 2 comments
Labels
refactor Refactoring and code clean-up

Comments

@sorawee
Copy link

sorawee commented Mar 12, 2020

Just curious: why don't we use the xml collection to convert Racket value to XML string? It's easier to manipulate xexpr, less error-prone, and probably more efficient than using string-append (which could theoretically take quadratic time in the size of the datum).

@mlavrent mlavrent added the refactor Refactoring and code clean-up label Mar 12, 2020
@mlavrent
Copy link
Collaborator

Yes - this is good to put on our todo list for when we go through and do a clean-up/refactoring. It was like this originally but got lost in the switch to/from json.

@asvarga
Copy link
Collaborator

asvarga commented Mar 13, 2020

I agree, I used it for the other direction (parsing xml models to partial instances) and it was way less painful. The bug patched today was caused by string difficulties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring and code clean-up
Projects
None yet
Development

No branches or pull requests

4 participants