Skip to content

Commit bbb6b67

Browse files
committed
Merge remote-tracking branch 'upstream/RC_v1.6.0' into sfreeman_xarray_work_fd_julia_avgs
2 parents 7f6930b + 5f82097 commit bbb6b67

File tree

53 files changed

+2807
-1872
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+2807
-1872
lines changed

.github/workflows/codecov-CI.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
mamba install --quiet --yes --file requirements.txt coverage pytest-cov &&
2828
python -m coverage run -m pytest --cov=./ --cov-report=xml
2929
- name: Upload Coverage to Codecov
30-
uses: codecov/codecov-action@v3
30+
uses: codecov/codecov-action@v4
3131
with:
3232
token: ${{ secrets.CODECOV_TOKEN }}
3333
fail_ci_if_error: true

.zenodo.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
{
2525
"name": "Kukulies, Julia",
26-
"affiliation": "University of Gothenburg (Sweden)",
26+
"affiliation": "NSF National Center for Atmospheric Research",
2727
"orcid": "0000-0001-6084-0069"
2828
},
2929
{

CHANGELOG.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,26 @@
11
### Tobac Changelog
22

3+
_**Version 1.5.3:**_
4+
5+
**Enhancements for Users**
6+
7+
- Update `calculate_area` to allow the calculation of the projected 2D area of 3D objects, and enhance bulk statistics to allow calculation of statistics on the projected footprint on 2D fields [#378](https://github.com/tobac-project/tobac/pull/378)
8+
9+
**Bug fixes**
10+
11+
- Fix a bug in `get_spacing` that would return a negative value if one coordinate was in ascending order and the other in descending order, and fix other bugs where the wrong coordinate was referenced [#400](https://github.com/tobac-project/tobac/pull/400)
12+
13+
**Documentation**
14+
15+
- Re-integration of notebooks from the tobac-tutorials repo [#334](https://github.com/tobac-project/tobac/pull/334)
16+
- Add example gallery to readthedocs page [#411](https://github.com/tobac-project/tobac/pull/411)
17+
18+
**Internal Enhancements**
19+
20+
- Add ability to save whether iris to xarray conversion ocurred and update decorators to allow keyword parameters [#380](https://github.com/tobac-project/tobac/pull/380)
21+
- Reorganisation of analysis tools into analysis package [#378](https://github.com/tobac-project/tobac/pull/378)
22+
23+
324
_**Version 1.5.2:**_
425

526
**Enhancements for Users**

CONTRIBUTING.md

Lines changed: 17 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -2,73 +2,48 @@
22

33
__Welcome! We are very happy that you are interested in our project and thanks for taking time to contribute! :)__
44

5-
We are currently reorganizing our project. So, please check our modifications later.
6-
75

86
## Getting Started
97
### Installation & Environment details
10-
You will find them in the [README.md](https://github.com/climate-processes/tobac/blob/master/README.md).
8+
You will find them in the [README.md](https://github.com/tobac-project/tobac/blob/master/README.md).
119

1210
### Tutorials
13-
Tutorials have been prepared to provide you further inside to `tobac`s functionality. Please visit the separate [tobac-tutorials](https://github.com/climate-processes/tobac-tutorials) repository here on Github.
14-
11+
Tutorials have been prepared to provide you further inside to `tobac`s functionality. Please have a look in the
12+
[examples folder](https://github.com/tobac-project/tobac/tree/main/examples).
1513

1614
### Documentation
1715
You will find our documentation at [https://tobac.readthedocs.io](https://tobac.readthedocs.io).
1816

1917
### Testing
2018
The tests are located in the [tests folder](https://github.com/climate-processes/tobac/tree/master/tobac/tests).
2119

22-
2320
## Reporting Bugs
24-
Please create a new issue on [GitHub](https://github.com/climate-processes/tobac/issues) if it is not listed there, yet.
21+
Please create a new issue on [GitHub](https://github.com/tobac-project/tobac/issues) if it is not listed there, yet.
2522

2623
### How to write a good Bug Report?
2724
* Give it a clear descriptive title.
2825
* Copy and paste the error message.
2926
* Describe the steps for reproducing the problem and give an specific example.
30-
* Optional: Make a suggestion to fix it.
31-
27+
* Optional: Make a suggestion to fix it.
3228

3329
## How to Submit Changes
34-
* Please read the [README.md](https://github.com/climate-processes/tobac/blob/master/README.md) first, to learn about our project goals and check the [changelog.md]().
35-
* Before you start a pull request, please make sure that you added [numpydoc docstrings](#docstringExample) to your functions. This way the api documentation will be parsed properly.
36-
* If it is a larger change or an newly added feature or workflow, please place an example of use in the [tobac-tutorials](https://github.com/climate-processes/tobac-tutorials) repository or adapt the existing examples there.
37-
* If necessary add a folder or modify a file.
30+
* Have a look at [our roadmap](https://github.com/tobac-project/tobac-roadmap/blob/master/tobac-roadmap-main.md) first,
31+
to learn about our project goals and check the
32+
[changelog.md](https://github.com/tobac-project/tobac/blob/main/CHANGELOG.md).
33+
* More details on the code structure and further help for code contributions can be found in our [developer
34+
guide](https://tobac.readthedocs.io/code_structure.html)
35+
* Before you start a pull request, please make sure that you added [numpydoc
36+
docstrings](https://numpydoc.readthedocs.io/en/latest/format.html) to your
37+
functions. See [docstring example in the developer guide](https://tobac.readthedocs.io/contributing.html). This way the
38+
api documentation will be parsed properly.
39+
* If it is a larger change or an newly added feature or workflow, please add an example in the [example
40+
folder](https://github.com/tobac-project/tobac/tree/main/examples) or adapt the existing examples there.
3841
* The code should be PEP 8 compliant, as this facilitates our collaboration. Please use the first stable version (22.6.0) of [black](https://black.readthedocs.io/en/stable/) to format your code. When you submit a pull request, all files are checked for formatting.
3942
* The tobac repository is set up with pre-commit hooks to automatically format your code when commiting changes. Please run the command "pre-commit install" in the root directory of tobac to set up pre-commit formatting.
4043

41-
We aim to respond to all new issues/pull requests as soon as possible, however at times this is not possible due to work commitments.
42-
43-
### Numpydoc Example <a name='docstringExample'>
44-
```python
45-
46-
'''
47-
calculate centre of gravity and mass forech individual tracked cell in the simulation
48-
49-
50-
Parameters
51-
----------
52-
tracks : pandas.DataFram
53-
DataFrame containing trajectories of cell centres
54-
55-
param mass : iris.cube.Cube
56-
cube of quantity (need coordinates 'time', 'geopotential_height','projection_x_coordinate' and
57-
'projection_y_coordinate')
58-
59-
param mask : iris.cube.Cube
60-
cube containing mask (int > where belonging to cloud volume, 0 everywhere else )
61-
44+
We aim to respond to all new issues/pull requests as soon as possible, however sometimes this is not possible due to work commitments.
6245

63-
Returns
64-
-------
65-
track_out : pandas.DataFrame
66-
Dataframe containing t,x,y,z positions of centre of gravity and total cloud mass each tracked cells
67-
at each timestep
68-
69-
'''
7046

71-
```
7247

7348
## Slack
7449
In addition to the workflow here on Github, there's a tobac workspace on Slack [tobac-dev.slack.com](tobac-dev.slack.com) that we use for some additional communication around the project. Please join us there to stay updated about all things tobac that go beyond the detailed work on the code.
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading

doc/bulk_statistics/notebooks/compute_statistics_during_feature_detection.ipynb

Lines changed: 54 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717
"execution_count": 1,
1818
"metadata": {
1919
"execution": {
20-
"iopub.execute_input": "2024-02-17T13:15:49.602971Z",
21-
"iopub.status.busy": "2024-02-17T13:15:49.602462Z",
22-
"iopub.status.idle": "2024-02-17T13:15:51.108332Z",
23-
"shell.execute_reply": "2024-02-17T13:15:51.106184Z"
20+
"iopub.execute_input": "2024-03-22T17:18:35.329188Z",
21+
"iopub.status.busy": "2024-03-22T17:18:35.328690Z",
22+
"iopub.status.idle": "2024-03-22T17:18:36.372987Z",
23+
"shell.execute_reply": "2024-03-22T17:18:36.372118Z"
2424
}
2525
},
2626
"outputs": [],
@@ -42,18 +42,18 @@
4242
"execution_count": 2,
4343
"metadata": {
4444
"execution": {
45-
"iopub.execute_input": "2024-02-17T13:15:51.115152Z",
46-
"iopub.status.busy": "2024-02-17T13:15:51.114024Z",
47-
"iopub.status.idle": "2024-02-17T13:15:54.249193Z",
48-
"shell.execute_reply": "2024-02-17T13:15:54.246812Z"
45+
"iopub.execute_input": "2024-03-22T17:18:36.376438Z",
46+
"iopub.status.busy": "2024-03-22T17:18:36.376057Z",
47+
"iopub.status.idle": "2024-03-22T17:18:38.247466Z",
48+
"shell.execute_reply": "2024-03-22T17:18:38.239280Z"
4949
}
5050
},
5151
"outputs": [
5252
{
5353
"name": "stdout",
5454
"output_type": "stream",
5555
"text": [
56-
"using tobac version 1.5.2\n"
56+
"using tobac version 1.5.3\n"
5757
]
5858
}
5959
],
@@ -68,10 +68,10 @@
6868
"execution_count": 3,
6969
"metadata": {
7070
"execution": {
71-
"iopub.execute_input": "2024-02-17T13:15:54.331271Z",
72-
"iopub.status.busy": "2024-02-17T13:15:54.324629Z",
73-
"iopub.status.idle": "2024-02-17T13:15:54.338758Z",
74-
"shell.execute_reply": "2024-02-17T13:15:54.336986Z"
71+
"iopub.execute_input": "2024-03-22T17:18:38.285861Z",
72+
"iopub.status.busy": "2024-03-22T17:18:38.285093Z",
73+
"iopub.status.idle": "2024-03-22T17:18:38.294187Z",
74+
"shell.execute_reply": "2024-03-22T17:18:38.292554Z"
7575
}
7676
},
7777
"outputs": [],
@@ -98,10 +98,10 @@
9898
"execution_count": 4,
9999
"metadata": {
100100
"execution": {
101-
"iopub.execute_input": "2024-02-17T13:15:54.351167Z",
102-
"iopub.status.busy": "2024-02-17T13:15:54.349280Z",
103-
"iopub.status.idle": "2024-02-17T13:15:54.367183Z",
104-
"shell.execute_reply": "2024-02-17T13:15:54.365164Z"
101+
"iopub.execute_input": "2024-03-22T17:18:38.322117Z",
102+
"iopub.status.busy": "2024-03-22T17:18:38.321283Z",
103+
"iopub.status.idle": "2024-03-22T17:18:38.331190Z",
104+
"shell.execute_reply": "2024-03-22T17:18:38.324702Z"
105105
}
106106
},
107107
"outputs": [],
@@ -114,10 +114,10 @@
114114
"execution_count": 5,
115115
"metadata": {
116116
"execution": {
117-
"iopub.execute_input": "2024-02-17T13:15:54.380965Z",
118-
"iopub.status.busy": "2024-02-17T13:15:54.372136Z",
119-
"iopub.status.idle": "2024-02-17T13:15:54.405551Z",
120-
"shell.execute_reply": "2024-02-17T13:15:54.401789Z"
117+
"iopub.execute_input": "2024-03-22T17:18:38.344343Z",
118+
"iopub.status.busy": "2024-03-22T17:18:38.344007Z",
119+
"iopub.status.idle": "2024-03-22T17:18:38.351035Z",
120+
"shell.execute_reply": "2024-03-22T17:18:38.349141Z"
121121
}
122122
},
123123
"outputs": [],
@@ -149,10 +149,10 @@
149149
"execution_count": 6,
150150
"metadata": {
151151
"execution": {
152-
"iopub.execute_input": "2024-02-17T13:15:54.424094Z",
153-
"iopub.status.busy": "2024-02-17T13:15:54.421895Z",
154-
"iopub.status.idle": "2024-02-17T13:15:54.722903Z",
155-
"shell.execute_reply": "2024-02-17T13:15:54.721785Z"
152+
"iopub.execute_input": "2024-03-22T17:18:38.370773Z",
153+
"iopub.status.busy": "2024-03-22T17:18:38.366590Z",
154+
"iopub.status.idle": "2024-03-22T17:18:38.505880Z",
155+
"shell.execute_reply": "2024-03-22T17:18:38.504723Z"
156156
}
157157
},
158158
"outputs": [],
@@ -165,10 +165,10 @@
165165
"execution_count": 7,
166166
"metadata": {
167167
"execution": {
168-
"iopub.execute_input": "2024-02-17T13:15:54.730863Z",
169-
"iopub.status.busy": "2024-02-17T13:15:54.729948Z",
170-
"iopub.status.idle": "2024-02-17T13:15:54.754780Z",
171-
"shell.execute_reply": "2024-02-17T13:15:54.754021Z"
168+
"iopub.execute_input": "2024-03-22T17:18:38.525114Z",
169+
"iopub.status.busy": "2024-03-22T17:18:38.522164Z",
170+
"iopub.status.idle": "2024-03-22T17:18:38.564211Z",
171+
"shell.execute_reply": "2024-03-22T17:18:38.562792Z"
172172
}
173173
},
174174
"outputs": [
@@ -223,7 +223,7 @@
223223
" margin-top: 7px;\n",
224224
" }\n",
225225
"</style>\n",
226-
"<table class=\"iris\" id=\"5155089680\">\n",
226+
"<table class=\"iris\" id=\"5282387344\">\n",
227227
" <tr class=\"iris\">\n",
228228
"<th class=\"iris iris-word-cell\">Surface Precipitation Average (mm h-1)</th>\n",
229229
"<th class=\"iris iris-word-cell\">time</th>\n",
@@ -333,10 +333,10 @@
333333
"execution_count": 8,
334334
"metadata": {
335335
"execution": {
336-
"iopub.execute_input": "2024-02-17T13:15:54.762881Z",
337-
"iopub.status.busy": "2024-02-17T13:15:54.759869Z",
338-
"iopub.status.idle": "2024-02-17T13:15:54.770105Z",
339-
"shell.execute_reply": "2024-02-17T13:15:54.767917Z"
336+
"iopub.execute_input": "2024-03-22T17:18:38.578722Z",
337+
"iopub.status.busy": "2024-03-22T17:18:38.575755Z",
338+
"iopub.status.idle": "2024-03-22T17:18:38.586793Z",
339+
"shell.execute_reply": "2024-03-22T17:18:38.584944Z"
340340
}
341341
},
342342
"outputs": [],
@@ -372,10 +372,10 @@
372372
"execution_count": 9,
373373
"metadata": {
374374
"execution": {
375-
"iopub.execute_input": "2024-02-17T13:15:54.773843Z",
376-
"iopub.status.busy": "2024-02-17T13:15:54.773535Z",
377-
"iopub.status.idle": "2024-02-17T13:15:54.788479Z",
378-
"shell.execute_reply": "2024-02-17T13:15:54.787618Z"
375+
"iopub.execute_input": "2024-03-22T17:18:38.608207Z",
376+
"iopub.status.busy": "2024-03-22T17:18:38.607420Z",
377+
"iopub.status.idle": "2024-03-22T17:18:38.618440Z",
378+
"shell.execute_reply": "2024-03-22T17:18:38.617527Z"
379379
}
380380
},
381381
"outputs": [],
@@ -412,10 +412,10 @@
412412
"execution_count": 10,
413413
"metadata": {
414414
"execution": {
415-
"iopub.execute_input": "2024-02-17T13:15:54.796799Z",
416-
"iopub.status.busy": "2024-02-17T13:15:54.796072Z",
417-
"iopub.status.idle": "2024-02-17T13:15:54.803867Z",
418-
"shell.execute_reply": "2024-02-17T13:15:54.803047Z"
415+
"iopub.execute_input": "2024-03-22T17:18:38.635746Z",
416+
"iopub.status.busy": "2024-03-22T17:18:38.635394Z",
417+
"iopub.status.idle": "2024-03-22T17:18:38.642691Z",
418+
"shell.execute_reply": "2024-03-22T17:18:38.640392Z"
419419
}
420420
},
421421
"outputs": [],
@@ -438,10 +438,10 @@
438438
"execution_count": 11,
439439
"metadata": {
440440
"execution": {
441-
"iopub.execute_input": "2024-02-17T13:15:54.816776Z",
442-
"iopub.status.busy": "2024-02-17T13:15:54.814862Z",
443-
"iopub.status.idle": "2024-02-17T13:15:54.833273Z",
444-
"shell.execute_reply": "2024-02-17T13:15:54.830306Z"
441+
"iopub.execute_input": "2024-03-22T17:18:38.665578Z",
442+
"iopub.status.busy": "2024-03-22T17:18:38.663868Z",
443+
"iopub.status.idle": "2024-03-22T17:18:38.672653Z",
444+
"shell.execute_reply": "2024-03-22T17:18:38.671135Z"
445445
}
446446
},
447447
"outputs": [],
@@ -454,10 +454,10 @@
454454
"execution_count": 12,
455455
"metadata": {
456456
"execution": {
457-
"iopub.execute_input": "2024-02-17T13:15:54.839903Z",
458-
"iopub.status.busy": "2024-02-17T13:15:54.839490Z",
459-
"iopub.status.idle": "2024-02-17T13:16:19.461680Z",
460-
"shell.execute_reply": "2024-02-17T13:16:19.460304Z"
457+
"iopub.execute_input": "2024-03-22T17:18:38.691608Z",
458+
"iopub.status.busy": "2024-03-22T17:18:38.691219Z",
459+
"iopub.status.idle": "2024-03-22T17:18:56.451127Z",
460+
"shell.execute_reply": "2024-03-22T17:18:56.450419Z"
461461
}
462462
},
463463
"outputs": [
@@ -504,10 +504,10 @@
504504
"execution_count": 13,
505505
"metadata": {
506506
"execution": {
507-
"iopub.execute_input": "2024-02-17T13:16:19.466025Z",
508-
"iopub.status.busy": "2024-02-17T13:16:19.465158Z",
509-
"iopub.status.idle": "2024-02-17T13:16:19.491494Z",
510-
"shell.execute_reply": "2024-02-17T13:16:19.490396Z"
507+
"iopub.execute_input": "2024-03-22T17:18:56.455395Z",
508+
"iopub.status.busy": "2024-03-22T17:18:56.454610Z",
509+
"iopub.status.idle": "2024-03-22T17:18:56.477335Z",
510+
"shell.execute_reply": "2024-03-22T17:18:56.476369Z"
511511
}
512512
},
513513
"outputs": [

0 commit comments

Comments
 (0)