Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PBC support to merge_split_MEST #371

Closed
w-k-jones opened this issue Nov 29, 2023 · 1 comment · Fixed by #372
Closed

Add PBC support to merge_split_MEST #371

w-k-jones opened this issue Nov 29, 2023 · 1 comment · Fixed by #372
Assignees
@w-k-jones
Labels
enhancement Addition of new features, or improved functionality of existing features
Milestone
Version 1.5.4

Comments

@w-k-jones
Copy link
Member

Adding support for periodic boundary conditions in merge_split_MEST would be a nice goal during the v1.5.x release cycle. This could be done using the scikit-learn BallTree distance search approach used in feature detection. This would replace the cdist distance search approach, which can cause memory issues for calculating merges/splits for large numbers of cells.

I'm working on adding this, but may need support from @kelcyno if I run into any unexpected issues
@w-k-jones w-k-jones self-assigned this Nov 29, 2023
@w-k-jones w-k-jones added the enhancement Addition of new features, or improved functionality of existing features label Nov 29, 2023
@w-k-jones w-k-jones added this to the Version 1.5.x milestone Nov 29, 2023
@w-k-jones w-k-jones linked a pull request Nov 29, 2023 that will close this issue
Add PBC capability to merge_split_MEST #372
Merged
11 tasks
@w-k-jones w-k-jones modified the milestones: Version 1.5.x, Version 1.5.3 Dec 2, 2023
@w-k-jones
Copy link
Member Author

Resolved with #372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w-k-jones w-k-jones

Labels
enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Milestone
Version 1.5.4
Development

Successfully merging a pull request may close this issue.

Add PBC capability to merge_split_MEST w-k-jones/tobac
1 participant
@w-k-jones