Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor @AndroidResources to use native #getString #99

Open
Buggaboo opened this issue Jan 28, 2016 · 0 comments
Open

Refactor @AndroidResources to use native #getString #99

Buggaboo opened this issue Jan 28, 2016 · 0 comments
Assignees
@Buggaboo
Labels
enhancement

Comments

@Buggaboo
Copy link
Contributor

As I coded it, I did not leverage the existing methods for getting strings from resources.

Activity#getString
Fragment#getString

So we have some code duplication with the basic SDK.

The active annotation @AndroidResources should determine whether the decorated type's a Fragment or Activity.
@Buggaboo Buggaboo self-assigned this Jan 28, 2016
@Buggaboo Buggaboo changed the title Refactor @AndroidResources to use native #getString (also #getText?) Refactor @AndroidResources to use native #getString Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Buggaboo Buggaboo

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Buggaboo